Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap packages fail validation #127081

Closed
joaomoreno opened this issue Jun 24, 2021 · 4 comments
Closed

Snap packages fail validation #127081

joaomoreno opened this issue Jun 24, 2021 · 4 comments
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders snap Issues related to the snap package verified Verification succeeded
Milestone
June 2021

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 24, 2021 •
edited
Loading

Snap packages are now failing validation with the following two errors:

  • found errors in file output: unusual mode 'rwsr-xr-x' for entry './usr/share/code-insiders/chrome-sandbox' security-snap-v2_squashfs_files
  • checksums do not match. Please ensure the snap is created with either 'snapcraft pack ' (using snapcraft >= 2.38) or 'mksquashfs -noappend -comp xz -all-root -no-xattrs -no-fragments' (using squashfs-tools >= 4.3). If using electron-builder, please upgrade to latest stable (>= 20.14.7). See https://forum.snapcraft.io/t/automated-reviews-and-snapcraft-2-38/4982/17 for details. security-snap-v2_squashfs_repack_checksum What does this mean?

Very likely broken by 92999c3, specifically 92999c3#diff-74c4ea7e8a7229121137b67faf75b6808d948fbbd120adb7b0f763a52b975dedR30-R32
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug snap Issues related to the snap package labels Jun 24, 2021
@joaomoreno joaomoreno added this to the June 2021 milestone Jun 24, 2021
@joaomoreno
Copy link
Member Author

joaomoreno commented Jun 24, 2021 •
edited
Loading

Relevant:

@deepak1556
Copy link
Collaborator

Where does the validation happen in our ci pipeline ? I was only checking the publish steps here https://dev.azure.com/monacotools/Monaco/_build/results?buildId=124711&view=results

@deepak1556 deepak1556 mentioned this issue Jun 24, 2021
Closed
@joaomoreno joaomoreno removed their assignment Jun 25, 2021
@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Jul 2, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Jul 6, 2021

@joaomoreno has the issue been fixed now? I'm not sure how one verifies this issue.

@deepak1556
Copy link
Collaborator

To verify locally SNAP_ENFORCE_RESQUASHFS=1 snap-review <path-to>/code-insiders.snap. I have verified this, marking accordingly.

@deepak1556 deepak1556 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jul 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@deepak1556
chore: disable sandbox on snap package
5b2263d 
Fixes microsoft#127081
Refs microsoft#127140
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders snap Issues related to the snap package verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

fix: snap package validation microsoft/vscode
5 participants
@joaomoreno @roblourens @deepak1556 @rzhao271 and others