Local terminal reconnection #116449

Tyriar · 2021-02-11T12:28:01Z

Supersedes #116370

This PR is part of #20013

… sizes

…iable files from workbench -> platform

Tyriar · 2021-02-11T12:36:47Z

I pushed the merged version of this into https://github.com/microsoft/vscode/tree/tyriar/megan_backup in case we needed it

src/vs/platform/terminal/common/terminal.ts

src/vs/platform/terminal/common/autoOpenBarrier.ts

src/vs/workbench/contrib/terminal/browser/terminalService.ts

src/vs/workbench/contrib/terminal/browser/terminalTab.ts

src/vs/platform/terminal/common/terminalProcess.ts

src/vs/platform/terminal/electron-main/localPtyMainService.ts

src/vs/platform/terminal/common/terminalProcess.ts

…latform

src/vs/base/common/async.ts

src/vs/base/parts/ipc/common/ipc.net.ts

src/vs/platform/terminal/common/terminal.ts

src/vs/platform/terminal/node/ptyService.ts

src/vs/workbench/contrib/terminal/common/terminal.ts

src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts

Co-authored-by: Daniel Imms <[email protected]>

src/vs/platform/terminal/common/environmentVariable.ts

src/vs/platform/terminal/common/terminal.ts

src/vs/platform/terminal/node/ptyService.ts

Co-authored-by: Daniel Imms <[email protected]>

Tyriar

Looked through all files, remaining to do:

Resolve the comments
Do a last check of TODOS
Fix remote conflicts and verify
Get CI passing

src/vs/workbench/contrib/terminal/common/terminal.ts

src/vs/workbench/contrib/terminal/electron-browser/terminalInstanceService.ts

Fixes #117028

meganrogge added 11 commits February 8, 2021 11:29

persist local terminals - not yet setting active instance or relative…

9fc381f

… sizes

remove log statement

4c690b3

active instance working for each tab

7dc31b4

touch up

b7882a8

relative sizes persist

4e0bc11

Merge branch 'merogge/localReconnect' into tyriar_megan_reconnect

662bc9b

create PersistentTerminalProcess and move terminal and environmentVar…

da39b7a

…iable files from workbench -> platform

Merge branch 'tyriar_megan_reconnect' into tyriar/megan

cd9704d

add log service

233890f

adjust resizePanes

ebebd48

add to do

1701859

Tyriar added this to the February 2021 milestone Feb 11, 2021

Tyriar assigned meganrogge Feb 11, 2021

Tyriar commented Feb 11, 2021

View reviewed changes

meganrogge and others added 2 commits February 11, 2021 06:21

Merge branch 'tyriar/megan' into tyriar_megan_reconnect

73e5f51

move things back to the workbench and leave only necessary items in p…

a35338b

…latform

Tyriar commented Feb 11, 2021

View reviewed changes

meganrogge and others added 9 commits February 11, 2021 11:22

Update src/vs/base/common/async.ts

53ac8d3

Co-authored-by: Daniel Imms <[email protected]>

Update src/vs/platform/terminal/common/terminal.ts

3bd49af

Co-authored-by: Daniel Imms <[email protected]>

move things back to platform and delete duplicate code

68a4751

Merge branch 'tyriar/megan' into tyriar_megan_reconnect

8dd7a21

remove unused imports

7e6e069

revert terminalTab change

d3502ea

remove unneeded stuff

c87e017

undo move of lines in test files

0c11d7c

change import for terminalContributionsDescriptor

fb354b7

Tyriar commented Feb 11, 2021

View reviewed changes

meganrogge and others added 2 commits February 11, 2021 15:02

Update src/vs/platform/terminal/common/terminal.ts

1e46aab

Co-authored-by: Daniel Imms <[email protected]>

move more stuff into/out of platform/terminal.ts

ff20de6

Tyriar and others added 6 commits February 19, 2021 10:48

Pty service better title handling

a59c8d2

Correct reconnected active terminal restoration

fc28fad

Clarify layout obj is not referencing pid

89eb214

Fix replay position

0f6ef54

Improve ptyService side log format

f3b46e3

Group common pty service interface methods

1475cd0

Handle shutting down all window processes when not a reload

04957f6

Tyriar commented Feb 19, 2021

View reviewed changes

Tyriar and others added 8 commits February 19, 2021 13:13

Remove duplicate interfaces from workbench

cf93ca4

Flow control constants to platform

cc92705

Remove unneeded event declaration

32a8133

Merge remote-tracking branch 'origin/main' into tyriar_megan_reconnect

6153932

Remove log

35d3403

Update distro

ad27576

Prevent env var reload when attaching

3c9cfee

Ensure pty host is shutdown when shared process goes down

5e01284

Tyriar mentioned this pull request Feb 22, 2021

Enable flow control for local processes on the ptyHost #116464

Closed

Tyriar added 4 commits February 22, 2021 03:46

Merge remote-tracking branch 'origin/main' into tyriar_megan_reconnect

d8b302d

Use less aggressive create process timeout

1bddccd

Disable conpty in integration tests again

d2a6dea

Fixes #117028

Make env var tests more resilient to other terminal events

ce7cd0a

Tyriar self-assigned this Feb 22, 2021

Tyriar merged commit d6846fa into main Feb 22, 2021

Tyriar deleted the tyriar_megan_reconnect branch February 22, 2021 12:48

This was referenced Feb 22, 2021

Retain terminal processes between window reloads #20013

Closed

Split terminals should be remembered between sessions #117242

Closed

github-actions bot locked and limited conversation to collaborators Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local terminal reconnection #116449

Local terminal reconnection #116449

Tyriar commented Feb 11, 2021

Tyriar commented Feb 11, 2021

Tyriar left a comment •

edited

Loading

Local terminal reconnection #116449

Local terminal reconnection #116449

Conversation

Tyriar commented Feb 11, 2021

Tyriar commented Feb 11, 2021

Tyriar left a comment • edited Loading

Choose a reason for hiding this comment

Tyriar left a comment •

edited

Loading