Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure closing a window doesn't take down local terminals of other windows #117089

Closed
Tyriar opened this issue Feb 19, 2021 · 1 comment
Closed

Make sure closing a window doesn't take down local terminals of other windows #117089

Tyriar opened this issue Feb 19, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
February 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 19, 2021 •
edited
Loading

Deferring from #116449

Repro (unconfirmed, might not actually happen):

  1. Open 2 windows
  2. Open a terminal in each
  3. Close one of the windows, the terminal in the other window should remain functional
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Feb 19, 2021
@Tyriar Tyriar added this to the February 2021 milestone Feb 19, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Feb 22, 2021

Seems to work fine

@Tyriar Tyriar closed this as completed Feb 22, 2021
@connor4312 connor4312 added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@Tyriar @connor4312 @meganrogge