Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the terminal cli ipc handle feature works in local terminals under pty host #117087

Closed
Tyriar opened this issue Feb 19, 2021 · 1 comment
Closed

Make sure the terminal cli ipc handle feature works in local terminals under pty host #117087

Tyriar opened this issue Feb 19, 2021 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
February 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 19, 2021 •
edited
Loading

I think it's currently broken. Deferring in #116449
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Feb 19, 2021
@Tyriar Tyriar added this to the February 2021 milestone Feb 19, 2021
@Tyriar Tyriar self-assigned this Feb 19, 2021
@meganrogge
Copy link
Contributor

meganrogge commented Feb 22, 2021 •
edited
Loading

To verify:

  • Launch VS Code
  • In Code - OSS, open vscode folder
  • In the terminal, run:
    ./scripts/code-cli.bat --wait somefile
  • Confirm there are no errors and a file opens called somefile
  • Reloading the window should display the persisted terminal(s) and they should still be responsive

@connor4312 connor4312 added the verified Verification succeeded label Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @meganrogge and others