Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support terminal link matchers in tasks v2 #21928

Closed
Tyriar opened this issue Mar 3, 2017 · 8 comments
Closed

Support terminal link matchers in tasks v2 #21928

Tyriar opened this issue Mar 3, 2017 · 8 comments
Assignees
@alexr00
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues terminal General terminal issues that don't fall under another label
Milestone
On Deck

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2017 •
edited
Loading

Part of tasks v2: #15179

Use ITerminalInstance.registerLinkMatcher to register expected regexes.
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label tasks Task system issues labels Mar 3, 2017
@Tyriar Tyriar added this to the March 2017 milestone Mar 3, 2017
@kieferrm kieferrm mentioned this issue Mar 3, 2017
Closed
58 tasks
@dbaeumer
Copy link
Member

Moved to April due to #23262, #23263, #23264

@dbaeumer dbaeumer modified the milestones: April 2017, March 2017 Mar 27, 2017
@dbaeumer dbaeumer modified the milestones: Mai 2017, April 2017 Apr 13, 2017
@dbaeumer
Copy link
Member

Moving due to shifted priorities.

@dbaeumer
Copy link
Member

Moving due to #23263

@dbaeumer dbaeumer modified the milestones: June 2017, May 2017 May 29, 2017
@dbaeumer dbaeumer modified the milestones: On Deck, June 2017 Jun 26, 2017
This was referenced Nov 9, 2017
Closed
Closed
Closed
@dbaeumer
Copy link
Member

Marking as dup of #21928 since there is no link matching planned in the old output runner.

@dbaeumer dbaeumer removed the feature-request Request for new features or functionality label Nov 10, 2017
@dbaeumer
Copy link
Member

Wrong issue :-).

@dbaeumer dbaeumer reopened this Nov 10, 2017
@dbaeumer dbaeumer mentioned this issue Nov 10, 2017
Closed
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Nov 10, 2017
@dbaeumer dbaeumer mentioned this issue Dec 12, 2017
Closed
@mdrichardson mdrichardson mentioned this issue Jun 4, 2019
Closed
@alexr00 alexr00 self-assigned this Oct 7, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 9, 2019

@alexr00 does tasks need this? What sort of links?

@alexr00
Copy link
Member

alexr00 commented Oct 10, 2019

I don't think so. It looks like this was going to be used to use the task problem matcher regex to make links in the terminal. But we have problems for nice links. The terminal also does a nice job of making links already.

@alexr00 alexr00 closed this as completed Oct 10, 2019
@alexr00 alexr00 added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@tmcguire
Copy link

Since this has been closed as out-of-scope, can #39920 be re-opened again? It was originally closed as a duplicate but looks like it has a smaller scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
4 participants
@tmcguire @dbaeumer @Tyriar @alexr00