Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link handler lifecycle problem / issue / question #23263

Closed
dbaeumer opened this issue Mar 27, 2017 · 2 comments
Closed

Link handler lifecycle problem / issue / question #23263

dbaeumer opened this issue Mar 27, 2017 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@dbaeumer
Copy link
Member

  • VSCode Version: master
  • OS Version: Windows

Since the task system re-uses terminals for different tasks I deregister link handlers when a task has completed (e.g. the exit event fired).

As a result the user can't click on links anymore (they are not recognized anymore). What is the idea for a client to when to deregister link handlers ?
@dbaeumer dbaeumer added the terminal General terminal issues that don't fall under another label label Mar 27, 2017
This was referenced Mar 27, 2017
Closed
Closed
@Tyriar
Copy link
Member

Tyriar commented Mar 27, 2017 •
edited
Loading

This was a known issue with the API I haven't followed up yet, upstream issue is here: xtermjs/xterm.js#551

Tentatively assigning to April

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 27, 2017
@Tyriar Tyriar added this to the April 2017 milestone Mar 27, 2017
@Tyriar Tyriar modified the milestones: April 2017, May 2017 Apr 23, 2017
@Tyriar Tyriar modified the milestones: Backlog, May 2017 May 12, 2017
@dbaeumer dbaeumer mentioned this issue Dec 12, 2017
Closed
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jun 21, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2018 •
edited
Loading

Let's track this upstream xtermjs/xterm.js#551

@Tyriar Tyriar closed this as completed Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dbaeumer @Tyriar