Link handler not firing

[dbaeumer]

• VSCode Version: master

I register the following link handler:

regexp: /^([^\s].*)\((\d+|\d+,\d+|\d+,\d+,\d+,\d+)\):\s+(error|warning|info)\s+(TS\d+)\s*:\s*(.*)$/
matchIndex: 1

no validator.

However no link is computed in the following terminal output:

> tsc -p .
Press any key to close the terminal
HelloWorld.ts(3,17): error TS2339: Property 'loog' does not exist on type 'Console'.

However IMO it should match the line.

[dbaeumer]

I couldn't even get a simple case like this to work: /(error|warning|info)/

Can you provide me with an example how to use the API to match an error message like

HelloWorld.ts(3,17): error TS2339: Property 'loog' does not exist on type 'Console'.

[Tyriar]

This worked fine for me:

registerLinkMatcher(/^([^\s].*)\((\d+|\d+,\d+|\d+,\d+,\d+,\d+)\):\s+(error|warning|info)\s+(TS\d+)\s*:\s*(.*)$/, console.log, 1)

Note that you need to hold ctrl/cmd now and also that the hover doesn't yet apply to custom link handlers (this is a bug which I'll fix up now).

[Tyriar]

Should work including the hint now:

[dbaeumer]

OK. Sorry for the noise then. I was expecting to see a blue underling link indication when hovering over it.

[Tyriar]

@dbaeumer this changed to align with the editor as much as possible. I didn't want to underline links by default due to lesser line-height than the editor and it could conflict with terminal styles.

[dbaeumer]

I found out why this isn't working for me. See #23262 and #23263