Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing problem in the terminal #23262

Closed
dbaeumer opened this issue Mar 27, 2017 · 1 comment
Closed

Timing problem in the terminal #23262

dbaeumer opened this issue Mar 27, 2017 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Mar 27, 2017

  • VSCode Version: master
  • OS: Windows

The terminal seems to have timing problems under Windows in terms of detecting and firing the exit event. I sometime see the following output:

Press any key to close the terminal
HelloWorld.ts(3,17): error TS2339: Property 'loog' does not exist on type 'Console'.

The problem here is that the terminal fires the exit event before it print Press any key to close the terminal. The task running framework stops parsing the output when the exit event is fired hence HelloWorld.ts(3,17): error TS2339: Property 'loog' does not exist on type 'Console'. is not recognized as being a valid output of the task anymore.

IMO the terminal should fire 'exit' or some other event when all output from the process is processed. I remember that in the output runner framework I was listening to close events on stdio as well to make sure I processed all output correctly.

@dbaeumer dbaeumer added terminal General terminal issues that don't fall under another label bug Issue identified by VS Code Team member as probable bug labels Mar 27, 2017
@Tyriar Tyriar added this to the April 2017 milestone Mar 27, 2017
@Tyriar Tyriar modified the milestones: April 2017, May 2017 Apr 23, 2017
@Tyriar
Copy link
Member

Tyriar commented May 20, 2017

Duplicate #23051

@Tyriar Tyriar closed this as completed May 20, 2017
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels May 20, 2017
@Tyriar Tyriar removed this from the May 2017 milestone May 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants