Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z-index issues with cell-title-toolbar #188974

Closed
Yoyokrazy opened this issue Jul 26, 2023 · 1 comment
Closed

z-index issues with cell-title-toolbar #188974

Yoyokrazy opened this issue Jul 26, 2023 · 1 comment
Assignees
@Yoyokrazy
Labels
bug Issue identified by VS Code Team member as probable bug notebook-sticky-scroll Sticky Scroll in Notebook Editor on-testplan
Milestone
December / Januar...

Comments

@Yoyokrazy
Copy link
Contributor

  • issues with z-index interactions between sash, nb sticky lines, and cell-title-toolbar.
    • the cell-title-toolbar was given the highest z-index to avoid issues with the sash.
    • the sticky lines are given a z-index under the sash to avoid overlapping visual bugs

Need to think about how the cell list view could be reworked to avoid this. The 'overlay' technique creates the z-index issues, so maybe needs a rework to have the cell list view sizing adjust alongside sticky...

image
@Yoyokrazy Yoyokrazy added the notebook-sticky-scroll Sticky Scroll in Notebook Editor label Jul 26, 2023
@Yoyokrazy Yoyokrazy added this to the August 2023 milestone Jul 26, 2023
@Yoyokrazy Yoyokrazy self-assigned this Jul 26, 2023
This was referenced Jul 26, 2023
Merged
Closed
@Yoyokrazy Yoyokrazy modified the milestones: August 2023, September 2023 Aug 31, 2023
@Yoyokrazy Yoyokrazy modified the milestones: September 2023, Backlog Sep 28, 2023
@Yoyokrazy Yoyokrazy added the bug Issue identified by VS Code Team member as probable bug label Dec 14, 2023
@kieferrm kieferrm mentioned this issue Jan 8, 2024
Closed
67 tasks
@Yoyokrazy Yoyokrazy mentioned this issue Jan 9, 2024
Merged
@Yoyokrazy
Copy link
Contributor Author

fixed via #201837

@Yoyokrazy Yoyokrazy mentioned this issue Jan 23, 2024
Closed
2 tasks
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
bug Issue identified by VS Code Team member as probable bug notebook-sticky-scroll Sticky Scroll in Notebook Editor on-testplan
Projects
None yet
Milestone
December / January 2024
Development

No branches or pull requests
3 participants
@Yoyokrazy @aiday-mar @vscodenpa