Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nb Sticky Scroll z-index & css fixes #201837

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Nb Sticky Scroll z-index & css fixes #201837

merged 8 commits into from
Jan 18, 2024

Conversation

Yoyokrazy
Copy link
Contributor

@Yoyokrazy Yoyokrazy commented Jan 4, 2024 •
edited
Loading

@Yoyokrazy Yoyokrazy self-assigned this Jan 4, 2024
Henderv
Henderv reviewed Jan 17, 2024
View reviewed changes
Copy link

@Henderv Henderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Yoyokrazy
Copy link
Contributor Author

Yoyokrazy commented Jan 17, 2024 •
edited
Loading

todo:

  • update testing to reflect new behavior changes
  • edge case for visible index 0 to avoid showing sticky line for a cell index 0 header (header to start a notebook, etc)

@Yoyokrazy Yoyokrazy marked this pull request as ready for review January 18, 2024 01:18
@vscodenpa vscodenpa added this to the December / January 2024 milestone Jan 18, 2024
@Yoyokrazy Yoyokrazy merged commit 309915b into main Jan 18, 2024
6 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/sticky-zindex-fix branch January 18, 2024 19:05
This was referenced Jan 18, 2024
Closed
Closed
Closed
Closed
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Henderv Henderv Henderv left review comments

@rebornix rebornix rebornix left review comments

@roblourens roblourens roblourens approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

z-index issues with notebooks sticky scroll
5 participants
@Yoyokrazy @roblourens @rebornix @Henderv @vscodenpa