Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run button/Cell Toolbar covered by Sticky Scroll #188690

Closed
rebornix opened this issue Jul 24, 2023 · 3 comments · Fixed by #188975
Closed

Run button/Cell Toolbar covered by Sticky Scroll #188690

rebornix opened this issue Jul 24, 2023 · 3 comments · Fixed by #188975
Assignees
@Yoyokrazy
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-sticky-scroll Sticky Scroll in Notebook Editor verified Verification succeeded
Milestone
July 2023

Comments

@rebornix
Copy link
Member

Does this issue occur when all extensions are disabled?: Yes/No

With sticky scroll enabled, the run button and cell toolbar no longer correctly move its position to say visible when we move a cell partially out of the viewport.
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-sticky-scroll Sticky Scroll in Notebook Editor labels Jul 24, 2023
@rebornix rebornix added this to the July 2023 milestone Jul 24, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Jul 24, 2023
Closed
3 tasks
@rebornix
Copy link
Member Author

image

Yoyokrazy added a commit that referenced this issue Jul 26, 2023
@Yoyokrazy
fix #188690 -- keep cell run and toolbar below sticky
d9f5aa2
@Yoyokrazy Yoyokrazy mentioned this issue Jul 26, 2023
Merged
Yoyokrazy added a commit that referenced this issue Jul 26, 2023
@Yoyokrazy
keep cell run and toolbar below sticky -- fix #188690 (#188975)
4ce8fad 
* fix #188690 -- keep cell run and toolbar below sticky

* chain operator to avoid undefined issues

* fallback value
@aiday-mar
Copy link
Contributor

aiday-mar commented Jul 27, 2023 •
edited
Loading

Looking good. The toolbar appears to move. I am just wondering if the toolbar should perhaps have a lower z-index than the sticky scroll? To avoid the following case

Screenshot 2023-07-27 at 17 47 37 Screenshot 2023-07-27 at 17 48 51

@aiday-mar aiday-mar added the verified Verification succeeded label Jul 27, 2023
@Yoyokrazy
Copy link
Contributor

I am just wondering if the toolbar should perhaps have a lower z-index than the sticky scroll?

Yep, that's being tracked here. Likely being taken care of during the next debt cycle.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-sticky-scroll Sticky Scroll in Notebook Editor verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

keep cell run and toolbar below sticky -- fix #188690 microsoft/vscode
4 participants
@rebornix @Yoyokrazy @aiday-mar and others