Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Notebook Sticky Scroll #188728

Closed
3 tasks done
Yoyokrazy opened this issue Jul 24, 2023 · 2 comments
Closed
3 tasks done

Test: Notebook Sticky Scroll #188728

Yoyokrazy opened this issue Jul 24, 2023 · 2 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Jul 24, 2023

Refs: #182444

Complexity: 3

Create Issue


Summary:

Notebooks now support a sticky scroll, resembling the standard editor experience. The notebook will track sticky "headers" based on markdown headers present in notebook md cells.

Steps to Test:

  • Enable sticky scroll via either of the following -- preferably try both :)

    • Use command palette View: Toggle Notebook Sticky Scroll
    • Use setting in UI or json notebook.stickyScroll.enabled
  • Ensure that you can toggle the setting via the command palette

  • Open a notebook with an assortment of markdown headers

    • Endgame notebooks work great, and you can find a couple examples littered in my testing repo.
  • Scroll until you have a sticky line/header rendered, and ensure you can right click, finding a context menu, and toggle the sticky scroll.

  • Click on the sticky line to focus the md cell with that header, ensure it is visible in the viewport.

  • Scroll up and down throughout various header sections and ensure there is no pop-in or out of multiple lines at a time. transitions are not animated as nicely as the editor sticky scroll, work for future here, but they should appear 1 at a time.

  • If you find any issues, I would greatly appreciate a gif of the bug, alongside the file you are using to test!

  • Any overall UX feedback is appreciated! This is early stages, and polish will be coming.

Known Bugs/Planned Work:

(feel free to reference or comment on these to bring attention/provide more examples)


Thanks so much for testing!

@hbons
Copy link
Member

hbons commented Jul 25, 2023

image
  • Confirmed I can click on the sticky line and the header becomes visible in the viewport
  • Confirmed sticky headers pop in/out as I'm scrolling the document.

What feels a bit weird to me that sticky headers can sometimes disappear. I don't get the logic behind it. Sticky headers should stick around. :)

@gregvanl
Copy link

gregvanl commented Jul 25, 2023

Tested on Windows 11.
Yep, I also found it confusing as to when a sticky header would appear.
Scrolling through woooooo.ipynb in the testing repo, I had to scroll several times past ### Sec before it would appear in the sticky scroll UI.
I would have expected the header to be displayed right after it scrolled out the top of the view port.
I also saw that headers higher in the hierarchy such as ## other header would disappear and reappear. Shouldn't the H2s remain as the H3s change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@hbons @Yoyokrazy @gregvanl @karrtikr and others