Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Sticky Scroll Folding + UX feedback #203097

Closed
2 tasks done
Yoyokrazy opened this issue Jan 23, 2024 · 2 comments
Closed
2 tasks done

Test: Sticky Scroll Folding + UX feedback #203097

Yoyokrazy opened this issue Jan 23, 2024 · 2 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Jan 23, 2024

Refs: #188974, #191561, #191632

Complexity: 3

Create Issue


Summary:

Notebook sticky scroll has gone through a couple more improvements, and now brings folding of markdown ranges to the table. In addition, there are two different UX styles to try out: flat, and indented. Settings are listed below
'notebook.stickyScroll.enabled': 'true'
'notebook.stickyScroll.mode': 'flat'
'notebook.stickyScroll.mode': 'indented'

Steps to Test:

  • Enable sticky scroll via either of the following
    • Use command palette View: Toggle Notebook Sticky Scroll
    • Use the setting in UI or json notebook.stickyScroll.enabled
  • Open a notebook with an assortment of markdown headers
    • Endgame notebooks are a great spot to test this feature, I know we all have them open :)
    • You can find a couple examples littered in my testing repo

During the following, toggle the indentation mode a bit, and try to work up some feedback on which you would prefer to see. There are a couple other instances of sticky scroll to compare/contrast against throughout VS Code, so feel free to bring up points you would like to see from others.

  • Scroll until you have a sticky line/header rendered, and do the following:
  • Click on the sticky line to focus the md cell with that header, ensure it is visible in the viewport.
  • Try folding sections of your notebook via the folding icon/chevron rendered in the sticky line.
  • If you find any issues, I would greatly appreciate a gif of the bug, alongside the file you are using to test! Any overall UX feedback is appreciated as well!

Thanks so much for testing!

@vscodenpa vscodenpa added this to the December / January 2024 milestone Jan 23, 2024
@aiday-mar
Copy link
Contributor

aiday-mar commented Jan 23, 2024

Great work! I feel that the indented mode looks better, as it highlights the hierarchical structure of the notebook

@cwebster-99
Copy link
Member

All looks good to me! I, too, prefer 'notebook.stickyScroll.mode': 'indented' because it helps me understand the organization of the notebook visually. To me, 'notebook.stickyScroll.mode': 'flat' doesn't fully represent the structure.

@cwebster-99 cwebster-99 removed their assignment Jan 23, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@WilmarE WilmarE mentioned this issue Feb 13, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants