Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned quote crashes Sass #17166

Closed
spritestack opened this issue Dec 14, 2016 · 4 comments · Fixed by #19655
Closed

Orphaned quote crashes Sass #17166

spritestack opened this issue Dec 14, 2016 · 4 comments · Fixed by #19655
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
February 2017

Comments

@spritestack
Copy link

  • VSCode Version: Code 1.7.2 (7ba55c5, 2016-11-21T22:01:10.756Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author Version

Steps to Reproduce:

  1. Open a new document
  2. Set language mode to Sass
  3. Type a quote mark " or ' and delete the closing quote if it's auto added.
    Any line of text with an orphaned quote mark will do.
  4. Move cursor to column 1 (start of the line) and press TAB.

Desired behaviour:
Pressing TAB should indent the text regardless of valid code etc.

The problem:
VSCode seems to freeze.
@kieferrm kieferrm added bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority labels Dec 14, 2016
@kieferrm kieferrm assigned ramya-rao-a and unassigned aeschli Dec 14, 2016
@kieferrm
Copy link
Member

The problem is caused by emmet.

@ramya-rao-a
Copy link
Contributor

emmetio/emmet#396

@ramya-rao-a ramya-rao-a added upstream Issue identified as 'upstream' component related (exists outside of VS Code) emmet Emmet related issues and removed important Issue identified as high-priority labels Dec 14, 2016
@ramya-rao-a
Copy link
Contributor

Happens if you press TAB anywhere inside the block

@rebornix rebornix mentioned this issue Dec 14, 2016
Merged
@ramya-rao-a ramya-rao-a mentioned this issue Feb 1, 2017
Merged
@ramya-rao-a ramya-rao-a added this to the February 2017 milestone Feb 1, 2017
@ramya-rao-a
Copy link
Contributor

Closing as duplicate of #8135

@ramya-rao-a ramya-rao-a added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
February 2017
Development

Successfully merging a pull request may close this issue.

Use patched emmet to support svg and orphaned quote bug microsoft/vscode
4 participants
@kieferrm @spritestack @aeschli @ramya-rao-a