Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode hangs by hitting <tab> in the editor (easily reproducible) #8135

Closed
pavlos256 opened this issue Jun 25, 2016 · 10 comments
Closed

vscode hangs by hitting <tab> in the editor (easily reproducible) #8135

pavlos256 opened this issue Jun 25, 2016 · 10 comments
Assignees
Labels
emmet Emmet related issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@pavlos256
Copy link

  • VSCode Version: 1.2.1
  • OS Version: Arch Linux

Steps to Reproduce:

  1. Save the following as a .css file:
.test {
white-space: pre-line;"
}
  1. Open the file in vscode.
  2. Place the cursor at the beginning of the second line (before white-space).
  3. Hit tab.

The editor hangs with 100% CPU on a core, needs kill -9 to die.

I am able to reproduce this every time without failure.

@rebornix
Copy link
Member

Reproduce on Mac with 1.3.0-Insider.

@dbaeumer dbaeumer added important Issue identified as high-priority editor labels Jun 25, 2016
@dbaeumer
Copy link
Member

@aeschli FYI.

@alexdima alexdima added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Jun 25, 2016
@alexdima
Copy link
Member

This is not a regression. Also happens in VS Code 1.2.1. Looks like emmet gets stuck in:

C:\Alex\src\vscode\node_modules\emmet\lib\parser\css.js:186 - function eatString()

Here are the locals I'm seeing in there, looks like that while loop never finishes:

image

@alexdima
Copy link
Member

alexdima commented Jun 25, 2016

We use [email protected]. Just checked and [email protected] also loops in there indefinitely.

@alexdima alexdima added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 25, 2016
@alexdima alexdima added this to the Backlog milestone Jul 13, 2016
@miparnisari
Copy link

I can reproduce this as well using VS Code 1.5.2 on Windows 10. After 15 seconds I get the "The window is no longer responding" popup.

@neculaiandrei
Copy link

@miparnisari Same here.

@alexdima
Copy link
Member

@miparnisari @neculaiandrei It is an issue with emmet -> emmetio/emmet#453

@pavlos256
Copy link
Author

If you don't use emmet, a workaround is to disable tab expansion with:

"emmet.triggerExpansionOnTab": false

@egamma egamma added the emmet Emmet related issues label Dec 15, 2016
@gianpaj
Copy link

gianpaj commented Jan 30, 2017

OMG @pavlos256 !! you're a life saver!!

I had trouble with a file.scss.liquid file without any VSCode extensions enabled and manually setting the file language to sass. (Mac OSX 10.11.6 - VSCode 1.8.1)

It took days to find this workaround! No stacktrace, just hangs... No idea if there's a way to enable debugging to better find the root cause of this

@ramya-rao-a
Copy link
Contributor

Fixed with #19655
The upstream emmet library has been fixed.
The fix will be available in the 1.10 insiders from tomorrow.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

9 participants