fix #396. Raise error when there is no matching quote. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Published as v1.6.1 |
ramya-rao-a
pushed a commit
to ramya-rao-a/emmet
that referenced
this pull request
Jan 31, 2017
ramya-rao-a
pushed a commit
to ramya-rao-a/emmet
that referenced
this pull request
Feb 1, 2017
ramya-rao-a
pushed a commit
to ramya-rao-a/emmet
that referenced
this pull request
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While troubleshooting issue microsoft/vscode#17166 for VS Code, we found the trigger is running
expandAbbreviationon a css rule without a closing quote, for example as belowThe root cause is that we don't quit the while loop while parsing quotes. We are handling brackets correctly, here this change is just aligning with other parts.