Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: vscode.dev PWA #141296

Closed
2 tasks done
joaomoreno opened this issue Jan 24, 2022 · 3 comments
Closed
2 tasks done

Test: vscode.dev PWA #141296

joaomoreno opened this issue Jan 24, 2022 · 3 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jan 24, 2022

Refs: #135553

Complexity: 3

Create Issue


We have enabled offline access in https://insiders.vscode.dev/, which is a core part of PWAs. Test that:

  • After using https://insiders.vscode.dev/ for a minute or so, you can go offline, open https://insiders.vscode.dev/ again and basic functionality should still work, especially local file editing. Core, built-in, extensions should work. Marketplace extensions don't.
  • When offline, the status bar should turn a red color and there should be a status bar item on the left indicating the offline status.
@joaomoreno joaomoreno added this to the January 2022 milestone Jan 24, 2022
@hello-smile6
Copy link
Contributor

@joaomoreno It works, at least partially. Here are some screenshots from VSCode Web on the Windows build of https://crrev.com/962708 . I used a temporary profile. If you'd like, I can provide data from the profile.
Recording 2022-01-24 at 15 43 17
Recording 2022-01-24 at 15 50 47

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2022

@joaomoreno I have done some very basic PWA testing since this is complexity 3 and because it seems like that some features are expectedly still not working. Please let me know if you would like me to give this a more thorough test pass and I can.

@kimadeline
Copy link

kimadeline commented Jan 26, 2022

Local file editing seems to be working reasonably well. At some point I managed to get in an in-between state when getting back online, with the "offline" status disappearing but the status bar still being red, I could search for extensions in the marketplace but the markdown preview wouldn't load. Sadly I haven't been able to repro it 😔

@kimadeline kimadeline removed their assignment Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants