Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more friendly error message(s) when offline #141762

Closed
chrisdias opened this issue Jan 28, 2022 · 5 comments
Closed

more friendly error message(s) when offline #141762

chrisdias opened this issue Jan 28, 2022 · 5 comments
Assignees
Labels
extensions Issues concerning extensions polish Cleanup and polish issue verification-found Issue verification failed
Milestone

Comments

@chrisdias
Copy link
Member

Testing #141296

When I am offline and search the marketplace, I get the message Error while fetching extensions. XHR failed. We know we are offline, suggest to have a friendlier error message here.

Unable to search the Marketplace when offline, please check your connection. or something like that.

@sandy081
Copy link
Member

@joaomoreno / @deepak1556 Is there an API to know if VS Code is offline?

At present, the internal request service does not provide any info about this.

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jan 31, 2022
@deepak1556
Copy link
Collaborator

In the renderer process you can use the navigator.onLine property and in the main process you can use net.isOnline method.

@sandy081 sandy081 added extensions Issues concerning extensions polish Cleanup and polish issue and removed info-needed Issue requires more information from poster labels Jan 31, 2022
@sandy081 sandy081 added this to the February 2022 milestone Jan 31, 2022
@sandy081
Copy link
Member

sandy081 commented Feb 1, 2022

image

@joyceerhl
Copy link
Collaborator

I see this in insiders.vscode.dev (PWA and web) still:
image
image

@joyceerhl joyceerhl reopened this Feb 24, 2022
@joyceerhl joyceerhl added the verification-found Issue verification failed label Feb 24, 2022
@sandy081
Copy link
Member

It works for me in insiders.vscode.dev - I turned off wifi for eg.,

image

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions polish Cleanup and polish issue verification-found Issue verification failed
Projects
None yet
Development

No branches or pull requests

6 participants
@joaomoreno @deepak1556 @chrisdias @sandy081 @joyceerhl and others