Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA: anycode does not work since it can not connect to server #141400

Closed
isidorn opened this issue Jan 25, 2022 · 5 comments
Closed

PWA: anycode does not work since it can not connect to server #141400

isidorn opened this issue Jan 25, 2022 · 5 comments
Assignees

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2022

Testing #141296

Open vscode.dev in PWA and open a typescript file. Notice anycode error
fyi @jrieken

Screenshot 2022-01-25 at 12 01 29

@joaomoreno
Copy link
Member

Marketplace extensions are not yet functional.

@jrieken
Copy link
Member

jrieken commented Jan 25, 2022

@joaomoreno Why is that marketplace related? The anycode extension seems installed but the message sounds more like an LSP setup issue, e.g the LSP server is likely meant but I need to drill into LSP bits to understand this further

@joaomoreno
Copy link
Member

An extension to be "installed" on vscode.dev means nothing. Even on a subsequent reload, the extension will be fetched from vscode-unpkg. So... if there's any dynamic loading that the extension does (ie request additional files at runtime), it could be that @isidorn was in a state in which he has the extension activated before going offline, went offline and then opened a TS file which made the extension load additional resources.

Does anycode do any dynamic loading?

@jrieken
Copy link
Member

jrieken commented Jan 25, 2022

Does anycode do any dynamic loading?

Yes, it starts its LSP server which is implemented in a different file (which is loaded from the extension "folder"). Tho, that is done immediately during activate

@joaomoreno
Copy link
Member

joaomoreno commented Jan 25, 2022

It can actually be something else: the mechanisms by which the entry point and the server are loaded are different. We currently do cache certain things from vscode-unpkg... but I believe that only covers the first mechanism.

Anyway, anycode is not core. We know extensions that are not core are not supported right now in offline.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants