Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA: Search not working when offline #141396

Closed
isidorn opened this issue Jan 25, 2022 · 2 comments
Closed

PWA: Search not working when offline #141396

isidorn opened this issue Jan 25, 2022 · 2 comments
Assignees
@joaomoreno
Labels
info-needed Issue requires more information from poster

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2022 •
edited by joaomoreno
Loading

Testing #141296

Search is not working in PWA, when offline

Screenshot 2022-01-25 at 11 57 59
@joaomoreno joaomoreno mentioned this issue Jan 25, 2022
Closed
@joaomoreno joaomoreno changed the title PWA: search not working PWA: Search not working when offline Jan 26, 2022
@joaomoreno
Copy link
Member

@isidorn Is this a GH repo?

I can't reproduce. My steps:

  1. Open https://insiders.vscode.dev
  2. Go offline
  3. Open folder
  4. Search for something. It works.

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jan 26, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Jan 26, 2022

Seems to work fine now, I can no longer repro. Feel free to close.
Maybe a clue why this was happening is the error "Unable to search with Web Worker text searcher"

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @isidorn