Spawning new terminal with workspace folder is broken since v1.62.0-insider

[drweb86]

Issue Type: Bug

1. Create workspace file

{
    "folders": [
        {
            "name": "scripts",
            "path": "."
        },
        {
            "name": "other",
            "path": ".//other"
        },
    ],
    "settings": {
        "terminal.integrated.cwd": "${workspaceFolder}",
    }
}

Create the other folder.
2. Open it in Visual Studio Code on Windows
3. Terminal \ New Terminal, select 'scripts'
4. Observe error:
The terminal process failed to launch: Starting directory (cwd) "D:\sources\app\scripts\D:\sources\app\scripts" does not exist.

VS Code version: Code - Insiders 1.62.0-insider (ff1e16e, 2021-10-29T05:16:23.014Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item	Value
CPUs	11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.66GB (21.15GB free)
Process Argv	--crash-reporter-id 084d9322-068c-436b-a87b-95494a395812
Screen Reader	no
VM	0%

[meganrogge]

Can you share your settings.json file and also do a trace log while creating a terminal? https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-trace-logging

[drweb86]

sharedLog.txt
mainLog.txt
rendererLog.txt

[drweb86]

settings_json.txt

[meganrogge]

Thanks, I don't see any logs indicating an attempt was made to create a terminal. Can you pls try again and capture the logs associated with that?

[drweb86]

@meganrogge should i wait before logs are written?

[meganrogge]

You should try to create the terminal (reproduce the bug) and then copy the logs which should contain information about the process

[drweb86]

@meganrogge, sorry, I missed important setting in repro. I've created reproducible sample.
app.zip

Unpack it and open workspace file. And then try to open any terminal

Seems like error is not stored in logs. I see
`
[2021-10-29 17:40:03.486] [renderer1] [trace] RequestService#request https://vscodeexperiments.azureedge.net/experiments/vscode-experiments.json

[2021-10-29 17:40:03.525] [renderer1] [trace] {"name":"EntryNotFound (FileSystemError)"}

[2021-10-29 17:40:03.525] [renderer1] [trace] {"name":"EntryNotFound (FileSystemError)"}

[2021-10-29 17:40:04.960] [renderer1] [trace] CommandService#executeCommand workbench.action.terminal.new

[2021-10-29 17:40:04.960] [renderer1] [trace] CommandService#executeCommand _workbench.pickWorkspaceFolder

[2021-10-29 17:40:06.367] [renderer1] [trace] terminalInstance#ctor (instanceId: 1) {"cwd":{"$mid":1,"path":"/d:/app/${workspaceFolder}","scheme":"file"}}

[2021-10-29 17:40:06.572] [renderer1] [debug] Terminal process exit (instanceId: 1) with code undefined

[2021-10-29 17:40:06.572] [renderer1] [debug] Terminal process exit (instanceId: 1) state 2

[2021-10-29 17:40:06.572] [renderer1] [trace] terminalInstance#dispose (instanceId: 1)`

[drweb86]

I've updated bug description with missing part

[stevenjoezhang]

I have reproduced a similar issue when setting "terminal.integrated.cwd": "${fileDirname}"

[stevenjoezhang]

The issue seems to be caused by commit 897ed30
I have replied here 897ed30#commitcomment-59916844

[drweb86]

@Tyriar @meganrogge In the latest insider build this bug it still reproduced with the exact same steps. However folder is different.

Before fix it concatenated it this way for folder "scripts"

"D:\sources\app\scripts\D:\sources\app\scripts"

After fix you can see the results below on screenshots:

This is shown when I try to open 'scripts' folder (from steps in bug)

This is shown when I try to open 'other' folder (from steps in bug)

As I can see, concatenation of relative paths became broken.

Should we reopen it?

[Tyriar]

@drweb86 good point, thanks for raising this. Didn't check the version info hard enough in your report

[drweb86]

I want to add some words of appreciation of VS Code. I'm using it for 4 years already and incredibly happy about it. And thinking about lots of efforts in the background that you @Tyriar, @meganrogge and other team members are putting to make this masterpiece editor, I feel envy that I'm not moving the entire world of development forward like you guys...