Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quickPickSeparators API proposal from package.json #18363

Closed
joyceerhl opened this issue Jan 25, 2022 · 2 comments · Fixed by #18384
Closed

Remove quickPickSeparators API proposal from package.json #18363

joyceerhl opened this issue Jan 25, 2022 · 2 comments · Fixed by #18384
Assignees
@karrtikr
Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Milestone
January 2022

Comments

@joyceerhl
Copy link

The Python extension's daily builds still declare the following API proposal, which @TylerLeonhardt has finalized in Insiders and which ship in the next stable release:

vscode-python/package.json

Line 24 in f660cb6

"quickPickSeparators",

This causes a warning in dev tools (cc @jrieken):

image
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 25, 2022
@jrieken
Copy link
Member

jrieken commented Jan 26, 2022

We can make this less dramatic - we have logic to detect a diff between enabled and wanted API proposals but in this case it's about an extension wanting a proposed that doesn't exist anymore. So that specific case could be handled with a more specialized message

jrieken added a commit to microsoft/vscode that referenced this issue Jan 26, 2022
@jrieken
better warning when an extension depends on an API proposal that does…
4a0927c 
…n't exist, microsoft/vscode-python#18363
@jrieken
Copy link
Member

jrieken commented Jan 26, 2022 •
edited
Loading

I have pushed a change that improves the warning on our end, tho a warning is the best we can do

sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 26, 2022
vscode: better warning when an extension depends on an API proposal t…
3c53507 
…hat doesn't exist, microsoft/vscode-python#18363

Commit: 4a0927c35658509e716592430f2955863382663e
@karthiknadig karthiknadig added area-editor-* User-facing catch-all triage debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed triage-needed Needs assignment to the proper sub-team labels Jan 26, 2022
@karrtikr karrtikr added needs PR and removed triage labels Jan 26, 2022
@karrtikr karrtikr mentioned this issue Jan 27, 2022
Merged
@karrtikr karrtikr added this to the January 2022 milestone Jan 27, 2022
@karrtikr karrtikr added the verified Verification succeeded label Jan 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Remove quickPickSeparators API proposal from package.json karrtikr/vscode-python
4 participants
@jrieken @karthiknadig @karrtikr @joyceerhl