Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text selection cursor is hard to see on older versions of macOS #96946

Closed
kdrag0n opened this issue May 4, 2020 · 0 comments · Fixed by #96947
Closed

Text selection cursor is hard to see on older versions of macOS #96946

kdrag0n opened this issue May 4, 2020 · 0 comments · Fixed by #96947
Assignees
@alexdima

Comments

@kdrag0n
Copy link
Contributor

kdrag0n commented May 4, 2020

  • VS Code Version: Code - Insiders 1.45.0-insider (fd5d9a3, 2020-05-04T09:21:17.770Z)
  • OS Version: macOS High Sierra 10.13.6

Steps to Reproduce:

  1. Switch to a dark theme
  2. Move mouse to the text area

Does this issue occur when all extensions are disabled?: Yes

This is a new issue caused by the removal of the special dark cursor in a915df1 to fix #94144. The default cursor is visible on macOS Catalina, but older versions of macOS don't have a text selection cursor that's visible on dark backgrounds. The old cursor can be fixed without removing it entirely.
@kdrag0n kdrag0n mentioned this issue May 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore and fix macOS dark text selection cursor
2 participants
@alexdima @kdrag0n