Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinking cursor outline when selecting with mouse #94144

Closed
EugeneDae opened this issue Apr 1, 2020 · 5 comments · Fixed by #96947
Closed

Blinking cursor outline when selecting with mouse #94144

EugeneDae opened this issue Apr 1, 2020 · 5 comments · Fixed by #96947
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone

Comments

@EugeneDae
Copy link

  • VSCode Version: 1.43.2
  • OS Version: macOS Catalina 10.15.3 (19D76)

Steps to Reproduce:

  1. Select text with a mouse and pay attention to the cursor: its outline would repeatedly appear and disappear at the rate of your movement. This doesn't happen in any other text editors and looks ugly.

Cursor with outline:
outline

Cursor without outline:
no-outline

If you select fast, the transformation happens fast as well, so most users probably don't notice it:
cursor-opt

Here's TextMate for comparison — buttery smooth:
cursor-tm-opt

Does this issue occur when all extensions are disabled?: Yes

@alexdima alexdima added macos Issues with VS Code on MAC/OS X editor-rendering Editor rendering issues labels Apr 1, 2020
@alexdima
Copy link
Member

alexdima commented Apr 1, 2020

I believe the OS is doing that, but I don't know why.

@EugeneDae
Copy link
Author

@alexdima The thin cursor is a custom cursor provided by VS Code:

cursor-css

Disabling this CSS rule fixes the issue for me.

@EugeneDae
Copy link
Author

To whoever lands here from Google, if you want to fix the issue described above, install Customize UI extension and add the following to your settings.json:

    "customizeUI.stylesheet": {
        ".monaco-editor.hc-black.mac .view-lines": "cursor: text !important;",
        ".monaco-editor.vs-dark.mac .view-lines": "cursor: text !important;"
    }

I've been using this for a month or so without any issues.

@alexdima
Copy link
Member

This special cursor came in via #4654 for #754 . It looks like macOS improved (possibly when they added support for dark OS themes?) and now they render a good text cursor by default.

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2020
@alexdima alexdima added this to the April 2020 milestone Apr 27, 2020
leilapearson pushed a commit to relmify/vscode that referenced this issue Apr 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 30, 2020

From what I can tell on my monitor and macOS Catalina this now looks good. Adding verified label.

@isidorn isidorn added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants