Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve terminal reconnection reliability #135481

Closed
Tyriar opened this issue Oct 20, 2021 · 4 comments
Closed

Improve terminal reconnection reliability #135481

Tyriar opened this issue Oct 20, 2021 · 4 comments
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Something that used to work is now broken terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone
October 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 20, 2021

It seems to not work sometimes in both the editor and the panel (eg. #127499). We should investigate and then write some tests in November.

I think it's a regression in Insiders as 1.61.0 works fine
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken terminal-persistence Relating to process reconnection or process revive labels Oct 20, 2021
@Tyriar Tyriar added this to the October 2021 milestone Oct 20, 2021
@Tyriar Tyriar added the important Issue identified as high-priority label Oct 20, 2021
@meganrogge
Copy link
Contributor

meganrogge commented Oct 20, 2021 •
edited
Loading

related #133741 - #133741 (comment)

@Tyriar Tyriar mentioned this issue Oct 21, 2021
Closed
@meganrogge
Copy link
Contributor

when getLayoutInfo happens, the ptys map and revivedPtyMap are both = {} and in expandInstance, the old id is correct and the newId is undefined

@Tyriar Tyriar mentioned this issue Oct 25, 2021
Closed
@Tyriar Tyriar removed their assignment Oct 25, 2021
meganrogge added a commit that referenced this issue Oct 25, 2021
@meganrogge
fix terminal reconnection on reload, rt of #135481
974c28e
@meganrogge
Copy link
Contributor

I believe the regression part of this issue has now been fixed.

@Tyriar Tyriar closed this as completed Oct 25, 2021
@meganrogge
Copy link
Contributor

to verify, reload the window - your terminals and their layout should persist

@joyceerhl joyceerhl added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Something that used to work is now broken terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge @joyceerhl