All powershell text turns yellow on reload

[andreamah]

Testing #127192

Steps:

1. Create side-by-side terminal editor tabs.
2. Type some stuff in one of the editors and then reload.
3. Do the same with the other editor.
4. The second editor should turn yellow

Recorded.with.FlexClip.Screen.Recorder.mp4

[Tyriar]

I'm guessing reply is happening twice, so the cursor which is yellow goes back to the top left and rewrites everything in that.

[Tyriar]

Code pointer:

vscode/src/vs/workbench/contrib/terminal/electron-sandbox/localPty.ts

Lines 110 to 128 in 923db71

	async handleReplay(e: IPtyHostProcessReplayEvent) {
	try {
	this._inReplay = true;
	for (const innerEvent of e.events) {
	if (innerEvent.cols !== 0 || innerEvent.rows !== 0) {
	// never override with 0x0 as that is a marker for an unknown initial size
	this._onProcessOverrideDimensions.fire({ cols: innerEvent.cols, rows: innerEvent.rows, forceExactSize: true });
	}
	const e: IProcessDataEvent = { data: innerEvent.data, trackCommit: true };
	this._onProcessData.fire(e);
	await e.writePromise;
	}
	} finally {
	this._inReplay = false;
	}
	// remove size override
	this._onProcessOverrideDimensions.fire(undefined);
	}

Moving out of June as it's kind of hard to repro and it's just a visual glitch. I had a quick look but couldn't see why it's happening exactly, I'm guessing it's related to how conpty/powershell will re-write the screen whenever it's resized.

[Tyriar]

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

[andreamah]

The terminal editor now doesn't re-open upon window reload (I'm assuming this is expected behavior), so technically the original issue is resolved.