Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to restore terminals (layout, not content) upon vscode restart #135687

Closed
hannah23280 opened this issue Oct 23, 2021 · 7 comments · Fixed by #136454
Closed

Request to restore terminals (layout, not content) upon vscode restart #135687

hannah23280 opened this issue Oct 23, 2021 · 7 comments · Fixed by #136454
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone

Comments

@hannah23280
Copy link

hannah23280 commented Oct 23, 2021

Hi,

I would like to request that upon restart vscode, the terminals can be restored.
By restored, i mean the layout, the custom names, icon and color for the terminals are retained. The content DOES NOT need to be retain.
Otherwise efforts to customize all the opened terminals would gone to waste when vscode is restarted.

Alternatively, vscode can provide new workspace configurations, where developer can manually enter a list of terminals' custom names, Vscode, upon starting, will automatically create new terminals based on the configured list. Even better, each time, deveoper manually open a new terminal , vscode will auto update the workspace configuration file to add a new terminal to the configured list. This applies the same to renaming of terminal

Hope that this can be achieved without relying on plugin.

*Do note that this might not be a duplicate of other look similar kind of feature request. Cos for this request, content does not need to be preserved. And the terminal's custom names should be preserved (sadly, persistentSessionReviveProcess, does not maintain the terminal custom names)

@meganrogge meganrogge added feature-request Request for new features or functionality terminal-persistence Relating to process reconnection or process revive labels Oct 25, 2021
@yume-chan
Copy link
Contributor

"terminal.integrated.persistentSessionReviveProcess": "onExit" except it doesn't save custom terminal names.

@hannah23280
Copy link
Author

"terminal.integrated.persistentSessionReviveProcess": "onExit" except it doesn't save custom terminal names.

Not only it doesn't save custom terminal names, it also doesn't save icon and color.

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2021

This is meant to be supported with terminal.integrated.persistentSessionReviveProcess including content as well, there are currently some issues with it causing it to be flaky though. They might have to wait until v1.63 where we will focus on testing.

Related: #135481

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Oct 25, 2021
@meganrogge
Copy link
Contributor

fixed 974c28e
recording - 2021-10-25T084103 000

@meganrogge
Copy link
Contributor

It's persisting the icon, color, name, and layout on window reload. Doesn't seem to persist icon, color, or name on restart.

@hannah23280
Copy link
Author

It's persisting the icon, color, name, and layout on window reload. Doesn't seem to persist icon, color, or name on restart.

Yes. My request is focusing on restart, not window reload

meganrogge added a commit that referenced this issue Nov 4, 2021
meganrogge added a commit that referenced this issue Nov 4, 2021
@roblourens roblourens added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@roblourens @yume-chan @Tyriar @hannah23280 @meganrogge and others