Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code Terminal doesn't autofocus #128255

Closed
LucasRafaelGoncalves opened this issue Jul 8, 2021 · 4 comments
Closed

VS Code Terminal doesn't autofocus #128255

LucasRafaelGoncalves opened this issue Jul 8, 2021 · 4 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release confirmed Issue has been confirmed by VS Code Team member terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
June 2021 Recovery 2

Comments

@LucasRafaelGoncalves
Copy link

VS Code Terminal doesn't autofocus when I create a new instance after update 1.58.0-1625728071
@vscodebot
Copy link

vscodebot bot commented Jul 8, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@biro456 biro456 mentioned this issue Jul 8, 2021
Closed
@biro456
Copy link

biro456 commented Jul 8, 2021

I'm also seeing this.

VS Code version: Code 1.58.0 (2d23c42, 2021-07-08T06:54:55.083Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info
Item Value
CPUs AMD Ryzen 5 3600X 6-Core Processor (12 x 3793)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.95GB (6.32GB free)
Process Argv --crash-reporter-id 4db21ffc-61bb-4e0f-84f1-1d0c8fc0bf39
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu-20.04
OS Linux x64 4.19.104-microsoft-standard
CPUs AMD Ryzen 5 3600X 6-Core Processor (4 x 3792)
Memory (System) 7.77GB (3.33GB free)
VM 0%
Extensions (20)
Extension Author (truncated) Version
project-manager ale 12.2.0
Handlebars and 0.4.1
dotenv mik 1.0.1
vscode-json5 mrm 1.0.0
remote-wsl ms- 0.58.2
proto pet 0.0.2
toml be5 0.5.1
vscode-eslint dba 2.1.23
EditorConfig Edi 0.16.4
vscode-graphql Gra 0.3.16
rainbow-csv mec 1.9.1
git-graph mhu 1.30.0
vscode-docker ms- 1.14.0
vscode-kubernetes-tools ms- 1.3.3
vscode-xml red 0.17.0
vscode-yaml red 0.21.0
rust rus 0.7.8
pdf tom 1.1.0
vscodeintellicode Vis 1.2.14
markdown-all-in-one yzh 3.4.0
A/B Experiments 
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30311712
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30335481
vscorehov:30309549
vscod805cf:30301675
pythonvspyt200:30331937
vscextlang:30333561
binariesv615:30325510
vstea450:30335276
bridge0708:30335490

@meganrogge meganrogge mentioned this issue Jul 9, 2021
Closed
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label confirmed Issue has been confirmed by VS Code Team member labels Jul 9, 2021
@meganrogge meganrogge added this to the June 2021 Recovery milestone Jul 9, 2021
@drgrib drgrib mentioned this issue Jul 9, 2021
Closed
@meganrogge meganrogge mentioned this issue Jul 9, 2021
Closed
@IllusionMH IllusionMH mentioned this issue Jul 9, 2021
Closed
@iamCristYe iamCristYe mentioned this issue Jul 12, 2021
Closed
@meganrogge meganrogge mentioned this issue Jul 12, 2021
Closed
@bboychris168
Copy link

I get this long line word when i open the terminal.
image

@Tyriar Tyriar mentioned this issue Jul 13, 2021
Closed
This was referenced Jul 13, 2021
Closed
Closed
@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2021

Repro:

  1. Load window without terminal showing
  2. ctrl+` to toggle terminal, it's focused correctly
  3. Kill it via bin icon
  4. ctrl+` to toggle terminal, it's not focused correctly 🐛

The single tab isn't present when this happens:

image

This is already fixed in insiders.

@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jul 14, 2021
Tyriar added a commit that referenced this issue Jul 14, 2021
@Tyriar
Unset active terminal group when last is removed
35b634d 
Part of #92649
Fixes #128255
Fixes #128236
@Tyriar Tyriar mentioned this issue Jul 14, 2021
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 14, 2021
@husjon husjon mentioned this issue Jul 16, 2021
Closed
@Ranguna Ranguna mentioned this issue Jul 31, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release confirmed Issue has been confirmed by VS Code Team member terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
June 2021 Recovery 2
Development

No branches or pull requests
6 participants
@biro456 @Tyriar @rzhao271 @LucasRafaelGoncalves @meganrogge @bboychris168