Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS: Could not move terminal into editor area after first move #128236

Closed
mahdi-farnia opened this issue Jul 8, 2021 · 4 comments
Closed

MacOS: Could not move terminal into editor area after first move #128236

mahdi-farnia opened this issue Jul 8, 2021 · 4 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
June 2021 Recovery 2

Comments

@mahdi-farnia
Copy link

Does this issue occur when all extensions are disabled?: Yes

Version: 1.58.0
Commit: 2d23c42
Date: 2021-07-08T06:54:17.694Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 20.5.0

Steps to Reproduce:

  1. Open terminal panel
  2. Move first terminal into editor area
  3. Open terminal panel again
  4. Terminal profile name & its icon disappeared

Screen Shot 1400-04-17 at 23 53 13
@meganrogge meganrogge added the info-needed Issue requires more information from poster label Jul 8, 2021
@meganrogge
Copy link
Contributor

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

@Tyriar
Copy link
Member

Tyriar commented Jul 8, 2021

I think this was fixed with #92649, let's consider for the recovery build if we are doing one.

@Tyriar Tyriar added this to the July 2021 milestone Jul 8, 2021
@Tyriar Tyriar added terminal General terminal issues that don't fall under another label and removed info-needed Issue requires more information from poster labels Jul 8, 2021
@Tyriar Tyriar self-assigned this Jul 8, 2021
@Tyriar Tyriar mentioned this issue Jul 8, 2021
Closed
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Jul 9, 2021
@Tyriar Tyriar mentioned this issue Jul 9, 2021
Closed
@mahdi-farnia
Copy link
Author

It hasn't fixed yet!
i upgraded vsCode to version 1.58.1
did you fix this issue in this update or it has fixed in insider release?

@mahdi-farnia
Copy link
Author

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

i don't have insider version, and i don't wanna install it (sorry, may be my sentences are a little like angry person but it's not 😅)

Tyriar added a commit that referenced this issue Jul 14, 2021
@Tyriar
Unset active terminal group when last is removed
35b634d 
Part of #92649
Fixes #128255
Fixes #128236
@Tyriar Tyriar mentioned this issue Jul 14, 2021
Merged
@Tyriar Tyriar closed this as completed Jul 14, 2021
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jul 14, 2021
@roblourens roblourens added the verified Verification succeeded label Jul 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
June 2021 Recovery 2
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @meganrogge @mahdi-farnia