Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base explorer refreshes on streamed events instead of polling so frequently #3680

Merged
merged 29 commits into from
Nov 8, 2022
Merged

Base explorer refreshes on streamed events instead of polling so frequently #3680

merged 29 commits into from
Nov 8, 2022

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Oct 28, 2022 •
edited
Loading

Fixes #3674, fixes #3595

@bwateratmsft bwateratmsft marked this pull request as ready for review November 3, 2022 17:39
@bwateratmsft bwateratmsft requested a review from a team as a code owner November 3, 2022 17:39
karolz-ms
karolz-ms reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharing my thoughts so far, will continue tomorrow

src/runtimes/docker/contracts/CommandRunner.ts Show resolved Hide resolved
src/runtimes/docker/contracts/CommandRunner.ts Outdated Show resolved Hide resolved
src/runtimes/docker/contracts/CommandRunner.ts Show resolved Hide resolved
karolz-ms
karolz-ms previously approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good, just a few suggestions/questions

src/runtimes/docker/contracts/ContainerClient.ts Outdated Show resolved Hide resolved
src/runtimes/runners/runWithDefaultShell.ts Show resolved Hide resolved
src/tree/RefreshManager.ts Show resolved Hide resolved
src/tree/RefreshManager.ts Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft mentioned this pull request Nov 7, 2022
Merged
@bwateratmsft bwateratmsft mentioned this pull request Nov 7, 2022
Closed
karolz-ms
karolz-ms approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bwateratmsft bwateratmsft merged commit ec71397 into main Nov 8, 2022
@bwateratmsft bwateratmsft deleted the bmw/eventStream branch November 8, 2022 20:05
@microsoft microsoft locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use docker events to avoid making so many CLI calls Fix the tree view's subpar tree ID behavior
2 participants
@bwateratmsft @karolz-ms