Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker events to avoid making so many CLI calls #3674

Closed
bwateratmsft opened this issue Oct 26, 2022 · 1 comment · Fixed by #3680
Closed

Use docker events to avoid making so many CLI calls #3674

bwateratmsft opened this issue Oct 26, 2022 · 1 comment · Fixed by #3680

Comments

@bwateratmsft
Copy link
Collaborator

When idling on the Docker explorer view, there's a small but noticeable increase in CPU usage, presumably due to all the CLI calls from polling. The docker events feature enables us to avoid making unnecessary polling calls. Probably the simplest approach (and what the container tools window in VS does) is to use it just as an event notification, but not actually use the data from the events. This would eliminate the need to poll on a schedule while still keeping the implementation of the current views essentially unchanged.

@bwateratmsft
Copy link
Collaborator Author

This has now been released in Docker extension version 1.23.0.

@microsoft microsoft locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant