Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In certain circumstances the docker events process can be leaked and left running #3692

Closed
bwateratmsft opened this issue Nov 9, 2022 · 1 comment · Fixed by #3693
Closed
Labels
Milestone

Comments

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Nov 9, 2022

I've been doing some experimentation and found that the docker events process started for #3674 can be "leaked" and left running. In normal VSCode shutdowns, the extension deactivates and the process is killed as expected. However, if I do "Reload Window", it seems that the deactivation pathway never occurs. The PowerShell process (on Windows) is killed properly, but the docker events process underneath it persists.

@bwateratmsft
Copy link
Collaborator Author

There's two potential solutions I can think of:

  1. Use the --until flag to put a maximum lifetime on the docker events process
  2. Don't run the process in a shell

@bwateratmsft bwateratmsft added this to the 1.23.0 milestone Nov 9, 2022
@dbreshears dbreshears added the P1 label Nov 9, 2022
@bwateratmsft bwateratmsft removed their assignment Nov 14, 2022
@microsoft microsoft locked and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants