Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tree view's subpar tree ID behavior #3595

Closed
bwateratmsft opened this issue Aug 1, 2022 · 2 comments · Fixed by #3680
Closed

Fix the tree view's subpar tree ID behavior #3595

bwateratmsft opened this issue Aug 1, 2022 · 2 comments · Fixed by #3680

Comments

@bwateratmsft
Copy link
Collaborator

The rapidly-changing tree ID causes some misbehaviors. For example when a container moves from "a few seconds ago" to "a minute ago" it changes IDs, so if the user right-clicked the container before the change to run a command, then it will prompt them to choose--this is redundant and annoying.

Ideally only the resource ID/name should be part of the tree ID. But, we need a way to cause a UI refresh when other data (such as state, etc.) changes.

@bwateratmsft bwateratmsft added this to the 1.24.0 milestone Aug 1, 2022
@bwateratmsft
Copy link
Collaborator Author

This could potentially be solvable with (or solved by) #3680.

@bwateratmsft
Copy link
Collaborator Author

I believe this is indeed fixed by #3680. In the past, we were polling the HTTP API regularly, and triggering updates essentially by altering the tree item ID. That was the root cause of the issue--the ID changing for what users would interpret to be the same object.

Now, we are no longer polling--we exclusively do full refreshes according to a handful of triggers (manual action by user, relevant event detected from docker events, relevant settings changes, and on a one-minute cycle as a catchall). The container status is no longer part of the tree item ID, only the state (running, stopped, etc.). The available actions differ enough from state to state that I'm OK with the IDs changing. Moreover, it's less likely to happen while the user is in the middle of trying to do some container action--unlike the timestamp which changes regularly and caused this bug initially.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant