Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and migrate old environment variable settings #3555

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jun 27, 2022

Closes #3539.

Settings migration could be a sticky issue. I want to verify the following, to be confident this feature will not break anything:

  • No notification if settings aren't used (covers vast majority of users)
  • Setting changes get picked up by context manager
  • Verify user -> user settings
  • Verify workspace -> workspace settings
  • Verify workspace folder -> workspace folder settings
  • Verify multiple setting targets combined
  • Verify multiple settings combined
  • Verify an empty workspace folder setting with non-empty user setting works? Nah

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
src/utils/addDockerSettingsToEnv.ts Show resolved Hide resolved
@bwateratmsft bwateratmsft marked this pull request as ready for review July 19, 2022 17:13
@bwateratmsft bwateratmsft requested a review from a team as a code owner July 19, 2022 17:13
karolz-ms
karolz-ms previously approved these changes Jul 19, 2022
@bwateratmsft bwateratmsft merged commit 280b3d3 into main Jul 20, 2022
@bwateratmsft bwateratmsft deleted the bmw/env branch July 20, 2022 16:04
@microsoft microsoft locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider deprecating docker.host, docker.context, etc. settings
3 participants