-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider deprecating docker.host
, docker.context
, etc. settings
#3539
Comments
/cc @chrmarti |
From telemetry data:
So the usage of these settings is extremely low. |
@Tyriar had an alternative idea I think I like better. Instead of using "containers.envVariables": {
"DOCKER_HOST": "...",
"SOME_VAR": "SOME_VALUE"
} We can apply this setting to |
I assume that could contain env variables for several CLIs? (E.g., Docker and Podman.) |
Yes, I think we would make it accept any environment variables, so that we don't have to chase many runtimes' particular environment variables. |
Associated docs PR: microsoft/vscode-docs#5488 |
This has now been released in Docker extension version 1.23.0. |
We're thinking about deprecating these settings, in favor of using VSCode's standard
terminal.env.<os>
option. I think that we would want to have a migration experience to help users get over to the new settings, as well as some documentation to describe how to set those.VSCode will apply those environment variables automatically to all terminal windows, but we would need to pick up and apply the appropriate setting for any shell tasks that we execute behind-the-scenes.
The text was updated successfully, but these errors were encountered: