Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The executing task is incorrect in terminal window if executing run image command after executing build image command #3580

Closed
v-ruizh opened this issue Jul 20, 2022 · 5 comments

Comments

@v-ruizh
Copy link

v-ruizh commented Jul 20, 2022

OS: Windows 10
Build Version: 20220713.1

Repro Steps:

  1. Open an Express app in VS Code and add Docker files to it.
  2. Right click the Dockerfile -> Build image.
  3. Navigate to the Image view -> Right click the express image and select "Run".
  4. Check whether the executing task is correct in terminal window.

Expect:
The executing task is correct in terminal window.
image

Actual:
The executing task is incorrect in terminal window.
image

More Info:
The executing task is right if only executing run image command.

@v-ruizh v-ruizh added the AT-CTI label Jul 20, 2022
@bwateratmsft
Copy link
Collaborator

This was done on the PR build for #3555, so could be related to that.

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Jul 20, 2022

@v-ruizh was this on VSCode Insiders or the main release? I was not able to reproduce on main.

@v-ruizh
Copy link
Author

v-ruizh commented Jul 22, 2022

@bwateratmsft Verified on the latest main Docker extension build 20220720.11, this issue also reproduces in VS Code Insiders. It does not reproduce in VS Code.

@bwateratmsft
Copy link
Collaborator

I am able to reproduce. This is only happening in Insiders and there haven't been changes in Docker in that area lately, so I suspect this must be a VSCode bug. I'll create an issue.

@bwateratmsft
Copy link
Collaborator

Verified this is fixed on the latest Insiders build.

@bwateratmsft bwateratmsft removed this from the 1.23.0 milestone Sep 27, 2022
@microsoft microsoft locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants