Use python3 as the Python path within containers
#2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philliphoff
reviewed
Nov 10, 2020
philliphoff
approved these changes
Nov 10, 2020
|
Yep, once we merge microsoft/vscode-python#14676 and microsoft/debugpy#467, this change should do the trick for you. |
|
Here's the extension build with the requisite change: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this comment, this should be the changes needed on the Docker side to fix #2455.
@int19h, if I understand the flow correctly, I think that the Python extension handles
debugAdapterPythonanddebugLauncherPython. ThedebugLauncherPythonPython interpreter will start our "launcher", which then unconditionally usespython3to start the real debugpy launcher inside the container: https://github.com/microsoft/vscode-docker/blob/master/resources/python/launcher.py#L17Then, using the
"python": "python3"option in this PR, the launcher inside the container usespython3to launch the app, which is what is desired.Does all this sound right?