Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python3 as the Python path within containers #2476

Merged
merged 16 commits into from
Nov 23, 2020
Merged
3 changes: 2 additions & 1 deletion src/debugging/python/PythonDebugHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ export class PythonDebugHelper implements DebugHelper {
program: debugConfiguration.file || pythonRunTaskOptions.file,
redirectOutput: debugConfiguration.redirectOutput || true,
args: args,
cwd: '.'
cwd: '.',
python: 'python3', // This controls what Python path gets used by the launcher to launch the debuggee. In a container we should always use `python3` to launch it.
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/tasks/python/PythonExtensionHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export namespace PythonExtensionHelper {

export async function getPythonExtension(): Promise<vscode.Extension<PythonExtensionAPI>> | undefined {
const pyExtensionId = 'ms-python.python';
const minPyExtensionVersion = new semver.SemVer('2020.5.78807');
const minPyExtensionVersion = new semver.SemVer('2020.5.78807'); // TODO
bwateratmsft marked this conversation as resolved.
Show resolved Hide resolved

const pyExt = vscode.extensions.getExtension(pyExtensionId);
const button = localize('vscode-docker.tasks.pythonExt.openExtension', 'Open Extension');
Expand Down