Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background of marketplace banner to match Docker logo #2499

Closed
philliphoff opened this issue Nov 17, 2020 · 3 comments · Fixed by #2476
Closed

Update background of marketplace banner to match Docker logo #2499

philliphoff opened this issue Nov 17, 2020 · 3 comments · Fixed by #2476
Labels
Milestone

Comments

@philliphoff
Copy link
Member

philliphoff commented Nov 17, 2020

With the switch to the new "blue whale" icon for the extension, we should update the background color of the banner shown in the marketplace, as the current blue-on-blue looks muddled.

Screenshot 2020-11-17 at 09 47 15

@bwateratmsft
Copy link
Collaborator

Huh, I would not have even guessed it was possible to control this, but now I noticed that galleryBanner setting in package.json for the first time.

@philliphoff
Copy link
Member Author

Yup! I'd go with a gray, but we wouldn't want it to clash with the gray and black already used in the header. Maybe a quick question for our UX expert?

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Nov 17, 2020

Good idea. I'm inclined toward #1e1e1e, which is the default editor background in the default dark theme--and also, what you see when you go to the Extensions tab.

Here's how that looks:
image

@bwateratmsft bwateratmsft added this to the 1.8.1 milestone Nov 17, 2020
@bwateratmsft bwateratmsft linked a pull request Nov 17, 2020 that will close this issue
@bwateratmsft bwateratmsft self-assigned this Nov 19, 2020
@bwateratmsft bwateratmsft removed their assignment Nov 23, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@philliphoff @bwateratmsft and others