Insert item #589
Merged
Insert item #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed so that all items in TreeView has the same context as the root Item.
|
FYI, you don't need to feel rushed, but but any features for the next release to be merged by early next week so we can schedule testing. Thanks. If not, that's fine, it'll go in the next release. |
|
Mostly this looks ready after the changes I suggested. We might play with the UI a bit afterwards, but nothing major I don't think. |
added 7 commits
May 1, 2020 16:11
StephenWeatherford
approved these changes
May 4, 2020
There was a problem hiding this comment.
Looks great, again much thanks!
A couple of minor bugs/fit-and-finish issues found after playing with it, entered those separately because I want to get this merged now.
#669 (should probably be fixed now)
#670 (lower priority items)
I'll fix #669 tomorrow or Wednesday if you can't or don't want to get to it, no worries.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the functionallity described in #508
It allows you to insert
The functionallity can be called by
Insert Function will always insert the new function in the first namespace (if it exists) otherwise it will create a new namespace.
Insert Resource will use the existing snippets to create a new resource but the user will be able to select which resource from a list that can be filtered.