Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert item #589

Merged
merged 69 commits into from
May 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
e2c93e0
Added icons for 6 new resource types in JsonOutlineProvider
Dec 13, 2019
b1e2a6d
Fixed icon for resource type config
Dec 13, 2019
5057095
Changed icon for "config" resource type
nilshedstrom Dec 14, 2019
1c9a815
Merge remote-tracking branch 'upstream/master'
nilshedstrom Dec 14, 2019
c0cc136
Added icon for functions. Refactored and improved icon tests.
nilshedstrom Dec 14, 2019
755a82c
Merge remote-tracking branch 'upstream/master'
nilshedstrom Dec 15, 2019
c72d87d
Merge remote-tracking branch 'upstream/master'
Dec 17, 2019
bce46a8
Added test for current icons for functions in Treeview
Dec 17, 2019
358a140
TreeView now shows icons for functions on 6 levels
Dec 17, 2019
9edc580
Treeview uses namespace as label if name and displayName is not present
Dec 17, 2019
66bda6f
Fixed bug when getting icons for a function without parameters
Dec 17, 2019
2d25b01
Updating TreeView after setting language to arm-template.
nilshedstrom Feb 11, 2020
08a1694
Merge remote-tracking branch 'upstream/master' into showTreeView
nilshedstrom Feb 11, 2020
bf6ecec
Merge remote-tracking branch 'upstream/master'
Mar 31, 2020
e26de41
Start of insertItem
Mar 31, 2020
03f642d
First working implementation of "Insert parameter"
Apr 1, 2020
07da143
Todo for insert parameter
Apr 1, 2020
af85827
Changed to template literal
Apr 1, 2020
d875c95
Added possibility to specify default value and description of parameter
Apr 1, 2020
c8214bd
Handle case when there is no parameters before
Apr 1, 2020
f9bd806
Initial support for 'Insert variable'
Apr 1, 2020
45614d5
InsertVariable sets the cursor position in the variable value
Apr 2, 2020
873def7
insertVariable now scrolls to cursor if needed
Apr 2, 2020
386add3
Merge remote-tracking branch 'upstream/master' into insertItem
Apr 2, 2020
7cfb95a
Implemented Insert Output
Apr 3, 2020
b02a804
Start of insert function
Apr 4, 2020
b1a41e8
Improved insert function
Apr 4, 2020
34763e3
Implemented Insert Resource
Apr 4, 2020
774a5dc
Added spaces to all 'Insert xxx'
Apr 4, 2020
f81d68a
Refactor insertParameter
Apr 5, 2020
d73ffe8
Refactoring of insertItem
Apr 5, 2020
37a0d7b
Refactored Insert Function
Apr 5, 2020
27b0369
Introduced types and fixed warnings in insertItem.ts
Apr 5, 2020
63c3745
Small fix for output value
Apr 5, 2020
45782d5
Started writing unit test for Insert Variable
Apr 7, 2020
8cf95f1
First passing test for Insert Variable
Apr 7, 2020
3b1d2ee
Testing insert variable with different settings
Apr 8, 2020
f1662ff
Minimized template to test
Apr 8, 2020
f7b7324
Improved tests for Insert Variable
Apr 9, 2020
1e33ce9
Added tests for Insert Output
Apr 9, 2020
a5dd788
Added tests that variables and outputs can be added to {}
Apr 9, 2020
a8383ae
Added tests for parameters
Apr 10, 2020
9e319e5
Added unit tests for Insert Function
Apr 10, 2020
274e596
Added one unit test for InsertResource
Apr 10, 2020
38b4370
Added test that verifies all snippets used by Insert Resource
Apr 10, 2020
a15465b
Improved tests for Insert Resource
Apr 12, 2020
a01ceec
Added error and information messages
Apr 12, 2020
4437a36
Cleanup of code
Apr 12, 2020
3b9eab9
Merge from master
Apr 12, 2020
8132b3f
Merge branch 'master' into insertItem
nilshedstrom Apr 12, 2020
4f0adc0
Fixed ending of merged files
Apr 12, 2020
bb584cc
Fixed white space changes in AzureRMTools.ts
Apr 12, 2020
8e04030
Fix lint error
Apr 12, 2020
9842551
Trying commenting failing test
Apr 17, 2020
519939c
Testing resource snippets used by Insert Resource in multiple tests
Apr 17, 2020
d776670
Changes based on feedback on PR
Apr 25, 2020
7beaf7a
Renamed SortType to TemplateSectionType
Apr 25, 2020
6af6f95
Refactored getContextValue in Treeview
Apr 25, 2020
8ff4f61
Merge remote-tracking branch 'upstream/master' into insertItem
Apr 25, 2020
e270057
Fixed failing unit tests
Apr 25, 2020
fb20dc2
Changed so that insertItem.getResourceSnippets reads
Apr 25, 2020
4e12e2d
Removed unused function testResourceSnippet in insertItem.test.ts
Apr 26, 2020
ffa0ad7
Changes to package.json based on feedback on PR
May 1, 2020
0e082bc
Moved TemplateSectionType to separate file
May 1, 2020
d40153c
Throw error instead of show error message in insertItem
May 1, 2020
3fad09f
Fixed indentation function
May 1, 2020
68f19a6
Made changes based on feedback on PR
May 1, 2020
26c73ce
Minor changes based on feedback on PR
May 2, 2020
4defcea
Fixed compilation error
May 2, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extension.bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export { HoverInfo } from "./src/Hover";
export { httpGet } from './src/httpGet';
export { DefinitionKind, INamedDefinition } from "./src/INamedDefinition";
export { IncorrectArgumentsCountIssue } from "./src/IncorrectArgumentsCountIssue";
export { InsertItem } from "./src/insertItem";
export { IParameterDefinition } from "./src/IParameterDefinition";
export * from "./src/Language";
export { LanguageServerState } from "./src/languageclient/startArmLanguageServer";
Expand All @@ -62,6 +63,7 @@ export { containsArmSchema, getPreferredSchema, isArmSchema } from './src/schema
export * from "./src/survey";
export { TemplatePositionContext } from "./src/TemplatePositionContext";
export { ScopeContext, TemplateScope } from "./src/TemplateScope";
export { TemplateSectionType } from "./src/TemplateSectionType";
export { FunctionSignatureHelp } from "./src/TLE";
export { JsonOutlineProvider, shortenTreeLabel } from "./src/Treeview";
export { UnrecognizedBuiltinFunctionIssue, UnrecognizedUserFunctionIssue, UnrecognizedUserNamespaceIssue } from "./src/UnrecognizedFunctionIssues";
Expand Down
3 changes: 3 additions & 0 deletions icons/insertItemDark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions icons/insertItemLight.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
49 changes: 49 additions & 0 deletions icons/sortDark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
49 changes: 49 additions & 0 deletions icons/sortLight.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading