Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert parameter should not put quotes around non-string default values #669

Closed
StephenWeatherford opened this issue May 4, 2020 · 2 comments
Closed

Insert parameter should not put quotes around non-string default values #669

StephenWeatherford opened this issue May 4, 2020 · 2 comments
Labels
bug P1
Milestone
0.10.0 (param fil...

Comments

@StephenWeatherford
Copy link
Contributor

  1. Insert a new int parameter with default value of 0.
    ACTUAL:
        "p4": {
            "type": "int",
            "defaultValue": "0"
        }

EXPECTED (no quotes):

        "p4": {
            "type": "int",
            "defaultValue": 0
        }
  1. Insert a new array parameter with default value []
    ACTUAL:
        "a1": {
            "type": "array",
            "defaultValue": "[]"
        }

EXPECTED: no quotes

etc. for object. Others?
@nilshedstrom
Copy link
Contributor

@StephenWeatherford
I am starting on it now.

@nilshedstrom nilshedstrom mentioned this issue May 4, 2020
Merged
@StephenWeatherford
Copy link
Contributor Author

Fixed by #671

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug P1
Projects
None yet
Milestone
0.10.0 (param files, resourceId etc I...
Development

No branches or pull requests
2 participants
@nilshedstrom @StephenWeatherford