Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VMs for July 2022 Patch Tuesday, and to Ubuntu 22.04. #25785

Merged
merged 10 commits into from
Jul 16, 2022

Conversation

BillyONeal
Copy link
Member

  • Changes the source from NVidia official for most CUDA things to Ubuntu's built in bits. Note that Ubuntu has no nccl so we're still getting that from them directly.
  • Updates PowerShell to 7.2.5.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jul 14, 2022
@Thomas1664
Copy link
Contributor

Finally we get gcc 11 which comes with c++ 20 🥳

@talregev
Copy link
Contributor

talregev commented Jul 14, 2022

@mkhon Update vm also for your PR:
#24934

@@ -56,22 +63,28 @@ APT_PACKAGES="$APT_PACKAGES libxdamage-dev"
# Additionally required by gtk3 and at-spi2-atk
APT_PACKAGES="$APT_PACKAGES libdbus-1-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APT_PACKAGES="$APT_PACKAGES libdbus-1-dev"
APT_PACKAGES="$APT_PACKAGES libdbus-1-dev libxtst-dev"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kinda too late. When I make this PR the image with the new configuration is already minted. :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC it is included three lines later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC it is included three lines later?

I don't see it

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be later in the script.

Copy link
Contributor

@talregev talregev Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show screen shots later on the script? It should near the line of libdbus-1-dev

Copy link
Contributor

@talregev talregev Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the old version of the script. The changes from this PR don't show up. Can you fix that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the old version of the script. The changes from this PR don't show up. Can you fix that?

Derp :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the old version of the script. The changes from this PR don't show up. Can you fix that?

Derp :)

How can we fix it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whack Bill over the head

@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member Author

Full build was totally green: https://dev.azure.com/vcpkg/public/_build/results?buildId=75152&view=results

(osx still running but a VM update doesn't affect osx)

Will merge as soon as PR run is green too.

@vicroms vicroms merged commit 68b7fec into microsoft:master Jul 16, 2022
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jul 16, 2022
Update VMs for July 2022 Patch Tuesday, and to Ubuntu 22.04. (microsoft#25785)
@BillyONeal BillyONeal deleted the vm-update branch July 18, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants