[new port] at-spi2-atk 2.38.0 port #24934

mkhon · 2022-05-26T09:11:23Z

at-spi2-atk 2.38.0 port
at-spi2-core 2.44.1 port

Describe the pull request

What does your PR fix?

The port provides at-spi2-atk dependency needed by gtk3

Which triplets are supported/not supported? Have you updated the CI baseline?

linux

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

mkhon · 2022-05-26T09:13:44Z

@talregev

talregev · 2022-05-26T09:34:22Z

@JackBoosY @dg0yt
Can you help?

mkhon · 2022-05-26T09:42:39Z

This port requires dbus (native dependency) to build.
I am not sure we should have dbus vcpkg port (like we don't have X11 ports).

JackBoosY · 2022-05-26T09:55:47Z

ports/at-spi2-core/vcpkg.json

+    "glib",
+    {
+      "name": "glib",
+      "host": true
+    },


Duplicated?

@mkhon Can you elaborate?

Second instance has host="true"

Second instance has host="true"

Why? it not enough with one? why we need 2?

The same as other gnome ports:

it uses glib tools (host)

It uses glib libs (target)

The same as other gnome ports:

it uses glib tools (host)

It uses glib libs (target)

Thank you for explaining! :)

Please resolve this thread.

talregev · 2022-05-26T12:32:57Z

This port requires dbus (native dependency) to build. I am not sure we should have dbus vcpkg port (like we don't have X11 ports).

@JackBoosY Is it possible to install dsub on the ci?
@mkhon this PR should search for dsub before and tell the user to install it if not exist. (or similar msgs we have).

mkhon · 2022-05-26T12:34:47Z

@talregev do we have similar examples (e.g. for searching X11 dependencies)?

talregev · 2022-05-26T12:37:11Z

@talregev do we have similar examples (e.g. for searching X11 dependencies)?

Yes.
Here some examples:
https://github.com/microsoft/vcpkg/blob/666afd19d1627452313e11cb01942397517f86c2/ports/sfml/portfile.cmake
https://github.com/microsoft/vcpkg/blob/277e9a7f4632029977626adc938a5a8bda675649/ports/glew/portfile.cmake
https://github.com/microsoft/vcpkg/blob/a9613b57751ea9dd7006f251ed1af1ccf3a808f9/ports/angle/portfile.cmake

talregev · 2022-05-26T12:43:56Z

@mkhon I write updated example for x11 msgs install msgs.
If not search, but only tell the user to install it also ok.

JackBoosY · 2022-05-27T02:39:46Z

ports/at-spi2-core/vcpkg.json

+    "glib",
+    {
+      "name": "glib",
+      "host": true


Suggested change

"host": true

"default-features": false,

"host": true

I don't understand why this change is required. I do not see this pattern to be used in the other ports (ports/gtk for example)

@JackBoosY Do you insist on this change?

JackBoosY · 2022-05-27T06:53:03Z

../src/ORE_2_44_1-fa40e2a5ad.clean/meson.build:52:0: ERROR: Dependency "dbus-1" not found, tried pkgconfig and cmake

Needs dbus-1?

talregev · 2022-05-27T07:04:30Z

../src/ORE_2_44_1-fa40e2a5ad.clean/meson.build:52:0: ERROR: Dependency "dbus-1" not found, tried pkgconfig and cmake

Needs dbus-1?

Yes. it need dbus. Can it install on the ci?

mkhon · 2022-05-31T14:07:29Z

I added a warning message that libdbus-1 is required and also disabled the build on CI because of this

dg0yt · 2022-06-01T04:17:58Z

I added a warning message that libdbus-1 is required and also disabled the build on CI because of this

This means that this port doesn't contribute to building wxwidgets:x64-linux in CI because it is going to block gtk3:x64-linux in CI.

FTR, port dbus may come with #22642.

talregev · 2022-06-01T05:28:36Z

also disabled the build on CI because of this

We need gtk linux so we also need at-spi2-atk port in Linux. please change that.

mkhon · 2022-06-01T07:32:58Z

@talregev

you still can build on Linux - it is just CI build that is currently disabled
the build will be enabled once all the dependencies are in the tree or dbus-1 dependency is added to CI

JackBoosY · 2022-06-01T09:09:55Z

Request install libdbus-1-dev on Linux.
cc @BillyONeal

talregev · 2022-06-03T08:38:20Z

I try to build at-spi-atk on my virtual linux machine. I install dbus lib.
There is an errors:

Installing 14/43 at-spi2-atk:x64-linux...
Building at-spi2-atk[core]:x64-linux...
-- at-spi2-atk currently requires the following libraries from the system package manager:
    libdbus-1

These can be installed on Ubuntu systems via apt-get install libdbus-1-dev
-- Downloading https://gitlab.gnome.org/GNOME/at-spi2-atk/-/archive/AT_SPI2_ATK_2_38_0/at-spi2-atk-AT_SPI2_ATK_2_38_0.tar.gz -> GNOME-at-spi2-atk-AT_SPI2_ATK_2_38_0.tar.gz...
-- Extracting source /home/ubuntu/vcpkg/downloads/GNOME-at-spi2-atk-AT_SPI2_ATK_2_38_0.tar.gz
-- Using source at /home/ubuntu/vcpkg/buildtrees/at-spi2-atk/src/ATK_2_38_0-a131295237.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Configuring x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
    Command failed: /usr/bin/python3 /home/ubuntu/vcpkg/installed/x64-linux/tools/meson/meson.py -Dtests=false --buildtype plain --backend ninja --wrap-mode nodownload --native /home/ubuntu/vcpkg/buildtrees/at-spi2-atk/meson-native-x64-linux.log --default-library static --libdir lib --native /home/ubuntu/vcpkg/buildtrees/at-spi2-atk/meson-native-x64-linux-debug.log -Ddebug=true --prefix /home/ubuntu/vcpkg/packages/at-spi2-atk_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/ubuntu/vcpkg/installed/x64-linux/debug','/home/ubuntu/vcpkg/installed/x64-linux'] /home/ubuntu/vcpkg/buildtrees/at-spi2-atk/src/ATK_2_38_0-a131295237.clean
    Working Directory: /home/ubuntu/vcpkg/buildtrees/at-spi2-atk/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/ubuntu/vcpkg/buildtrees/at-spi2-atk/config-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:470 (vcpkg_execute_required_process)
  ports/at-spi2-atk/portfile.cmake:13 (vcpkg_configure_meson)
  scripts/ports.cmake:146 (include)

config-x64-linux-dbg-out.log
@mkhon Can you fix it?

talregev · 2022-08-11T04:36:15Z

The current image don't contain libxtst-dev. (or any of the changes for linux).

This is not correct:

@BillyONeal This is correct. I just remain you our conversation here:
#25785 (comment)

The vm image is not correlated anymore to vcpkg/scripts/azure-pipelines/linux/provision-image.sh.
They are different. In the current vm there is the old script before the merge.
This is your a screenshot from current vm:

JackBoosY · 2022-08-11T07:14:37Z

ports/at-spi2-core/portfile.cmake

@@ -0,0 +1,48 @@
+if(VCPKG_TARGET_IS_LINUX)
+    message(STATUS "${PORT} currently requires the following libraries from the system package manager:\n    libdbus-1\n    libxi-dev\n    libxtst-dev\n\nThese can be installed on Ubuntu systems via apt-get install libdbus-1-dev libxi-dev libxtst-dev")


Suggested change

message(STATUS "${PORT} currently requires the following libraries from the system package manager:\n libdbus-1\n libxi-dev\n libxtst-dev\n\nThese can be installed on Ubuntu systems via apt-get install libdbus-1-dev libxi-dev libxtst-dev")

message(STATUS "${PORT} currently requires the following libraries from the system package manager:\n libdbus-1-dev\n libxi-dev\n libxtst-dev\n\nThese can be installed on Ubuntu systems via apt-get install libdbus-1-dev libxi-dev libxtst-dev")

JackBoosY · 2022-08-11T07:16:29Z

I don't have access to merge master branch to this branch, please merge it first. Then I will check the logs.

BillyONeal · 2022-08-11T08:40:43Z

This is your a screenshot from current vm:

The line that installs the package in question is off the bottom of the screenshot. It's theoretically possible that I accidentally created the new VMSS pointing to the old image or something like that but it would be very surprising to me.

Notably, that screenshot was not from the VM itself (they are headless, no GUI)

talregev · 2022-08-11T09:02:45Z

This is your a screenshot from current vm:

The line that installs the package in question is off the bottom of the screenshot. It's theoretically possible that I accidentally created the new VMSS pointing to the old image or something like that but it would be very surprising to me.

Notably, that screenshot was not from the VM itself (they are headless, no GUI)

How you can verify what is actually found on the vm?
Is it possible that is your vscode connect with ssh remote to the vm?

talregev · 2022-08-11T14:54:59Z

This is your a screenshot from current vm:

The line that installs the package in question is off the bottom of the screenshot. It's theoretically possible that I accidentally created the new VMSS pointing to the old image or something like that but it would be very surprising to me.

Notably, that screenshot was not from the VM itself (they are headless, no GUI)

@BillyONeal
This is the old version of the script. This is the version before the merge. If you can take a look closely just from the missing line here:
https://github.com/microsoft/vcpkg/pull/25785/files#diff-e297fefc9e4af531208557e0f979ee877017c49c901bb418ac4672f50c074319R12
That we are looking on the old version of the script before the merge. So I know for sure from the screenshot that there isn't the libxtst in the file, more as you can see you already search for it inside the vscode, and it didn't find it.

talregev · 2022-08-11T14:55:37Z

This is your a screenshot from current vm:

The line that installs the package in question is off the bottom of the screenshot. It's theoretically possible that I accidentally created the new VMSS pointing to the old image or something like that but it would be very surprising to me.

Notably, that screenshot was not from the VM itself (they are headless, no GUI)

@BillyONeal Can you update the vm with the current vcpkg/scripts/azure-pipelines/linux/provision-image.sh file?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for at-spi2-atk have changed but the version was not updated
version: 2.38.0
old SHA: ebb28a9cdbd06d3185ba2e0cfc1945be23a0a608
new SHA: d3bad232e464a2089180b36b06b118aa46bf2e92
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for at-spi2-core have changed but the version was not updated
version: 2.44.1
old SHA: dd1e736f89692df6c27db81eed2269458666841b
new SHA: b845424faf2dfa477546f9c23a900f789f506eb2
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

at-spi2-core 2.44.1 port

JackBoosY · 2022-08-12T06:29:44Z

Can you enable editing by other contributors?

mkhon · 2022-08-12T06:39:17Z

github does not allow that for organizations

…

On Fri, 12 Aug 2022 at 13:29 Jack·Boos·Yu ***@***.***> wrote: Can you enable editing by other contributors? — Reply to this email directly, view it on GitHub <#24934 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXB7HNNNQZ3FGKGL6FDOWTVYXVOHANCNFSM5XANH5TA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

talregev · 2022-08-12T06:50:02Z

github does not allow that for organizations

@mkhon Can I copy your PR and let @JackBoosY to edit this PR?

JackBoosY · 2022-08-12T08:04:42Z

Port libxtst and its dependency xorg-macros:

ports.zip

Current situation:
libxtst couldn't find xorg-macros's macro:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force 
configure.ac:37: error: must install xorg-macros 1.12 or later before running autoconf/autogen
configure.ac:37: the top level
autom4te: error: /usr/bin/m4 failed with exit status: 1
aclocal-1.16: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1

Another way: install xutils-dev with apt or other package manager instead of adding xorg-macros.

BillyONeal · 2022-08-12T21:13:02Z

Wow, I can't believe I messed up the Linux deployment like that. Clearly it didn't work because the Pipelines Agent hates Ubuntu 22.04, so the attempted update there to get more modern compilers didn't actually land. (That is, we fail due to microsoft/azure-pipelines-agent#3834 )

Putting the tag back....

japm48 · 2022-08-13T18:17:52Z

@BillyONeal So, apparently according to microsoft/azure-pipelines-agent#3834 we have to wait for the port to .Net 6.

Would it be possible to make use of the OpenSSL downgrade workaround in the meantime?

JackBoosY · 2022-08-15T02:49:56Z

@BillyONeal So, apparently according to microsoft/azure-pipelines-agent#3834 we have to wait for the port to .Net 6.

Would it be possible to make use of the OpenSSL downgrade workaround in the meantime?

No, we shouldn't downgrade the version unless the port is seriously buggy.

japm48 · 2022-08-15T11:15:15Z

@JackBoosY @BillyONeal

In that case I would suggest another workaround: create a file /etc/ssh/ssh_config.d/enable_rsa_sha.conf with the contents:

KexAlgorithms +diffie-hellman-group14-sha1,diffie-hellman-group1-sha1
MACs +hmac-sha1
HostKeyAlgorithms +ssh-rsa
PubkeyAcceptedKeyTypes +ssh-rsa
PubkeyAcceptedAlgorithms +ssh-rsa

Source: https://rwmj.wordpress.com/2022/08/08/ssh-from-rhel-9-to-rhel-5-or-rhel-6/
(I also added diffie-hellman-group1-sha1 as that looks like it is also needed according to my other search results)

If the server (sshd) also needs to be configured, create the file /etc/ssh/sshd_config.d/enable_rsa_sha.conf with the same contents.

BillyONeal · 2022-08-15T19:16:06Z

Would it be possible to make use of the OpenSSL downgrade workaround in the meantime?

I'm a bit nervous doing that. The purpose of our CI testing is to replicate something one of our users is actually likely to do, and by and large they aren't going to have applied changes like that.

Would it be possible to make use of the OpenSSL downgrade workaround in the meantime?

No, we shouldn't downgrade the version unless the port is seriously buggy.

@japm48 is talking about the version installed by apt on our Linux CI fleet, not the one installed by any of our ports.

talregev · 2022-08-16T04:02:57Z

@BillyONeal
Can you switch to 20.04 with all the new apt packages install, and when you solve the 22.04 bug you can switch it?

mkhon · 2022-09-09T09:43:11Z

@BillyONeal @talregev what is the current status of this?

Can we push gtk3 without Linux build for now? This is long overdue

talregev · 2022-09-09T10:54:53Z

github does not allow that for organizations

@mkhon Can I copy your PR and let @JackBoosY to edit this PR?

@mkhon Please respond to this comment.

mkhon · 2022-09-12T18:31:59Z

I created #26766 which is made from the non-org-owned fork so that edits should be allowed

github-actions bot approved these changes May 26, 2022

View reviewed changes

mkhon mentioned this pull request May 26, 2022

[new port] gtk 3.24.34 port #22201

Closed

JackBoosY self-assigned this May 26, 2022

JackBoosY changed the title ~~at-spi2-atk 2.38.0 port~~ [new port] at-spi2-atk 2.38.0 port May 26, 2022

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 26, 2022

github-actions bot approved these changes May 26, 2022

View reviewed changes

JackBoosY reviewed May 26, 2022

View reviewed changes

JackBoosY suggested changes May 27, 2022

View reviewed changes

JackBoosY added the requires:author-response label May 27, 2022

github-actions bot approved these changes May 31, 2022

View reviewed changes

dg0yt mentioned this pull request Jun 1, 2022

[at-spi2-atk, at-spi2-core] Add new port #25010

Closed

JackBoosY added depends:vm-update PR contains changes to the VM provisioning scripts and removed requires:author-response labels Jun 1, 2022

github-actions bot approved these changes Jun 2, 2022

View reviewed changes

JackBoosY suggested changes Aug 11, 2022

View reviewed changes

JackBoosY added the requires:author-response label Aug 11, 2022

mkhon dismissed github-actions[bot]’s stale review via 12f3b37 August 12, 2022 06:01

github-actions bot requested changes Aug 12, 2022

View reviewed changes

at-spi2-atk 2.38.0 port

6ec44b5

at-spi2-core 2.44.1 port

github-actions bot approved these changes Aug 12, 2022

View reviewed changes

BillyONeal added depends:vm-update PR contains changes to the VM provisioning scripts and removed requires:author-response labels Aug 12, 2022

theartful mentioned this pull request Sep 10, 2022

build(vcpkg): Support building synfig using vcpkg on linux synfig/synfig#2825

Open

mkhon closed this Sep 12, 2022

mkhon deleted the feature/at-spi2-atk branch September 28, 2022 19:01

		@@ -0,0 +1,48 @@
		if(VCPKG_TARGET_IS_LINUX)
		message(STATUS "${PORT} currently requires the following libraries from the system package manager:\n libdbus-1\n libxi-dev\n libxtst-dev\n\nThese can be installed on Ubuntu systems via apt-get install libdbus-1-dev libxi-dev libxtst-dev")

[new port] at-spi2-atk 2.38.0 port #24934

[new port] at-spi2-atk 2.38.0 port #24934

Conversation

mkhon commented May 26, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

mkhon commented May 26, 2022

talregev commented May 26, 2022

mkhon commented May 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

talregev commented May 26, 2022 • edited Loading

mkhon commented May 26, 2022

talregev commented May 26, 2022 • edited Loading

talregev commented May 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JackBoosY commented May 27, 2022

talregev commented May 27, 2022

mkhon commented May 31, 2022

dg0yt commented Jun 1, 2022

talregev commented Jun 1, 2022 • edited Loading

mkhon commented Jun 1, 2022 • edited Loading

JackBoosY commented Jun 1, 2022

talregev commented Jun 3, 2022

talregev commented Aug 11, 2022 • edited Loading

Choose a reason for hiding this comment

JackBoosY commented Aug 11, 2022

BillyONeal commented Aug 11, 2022

talregev commented Aug 11, 2022 • edited Loading

talregev commented Aug 11, 2022

talregev commented Aug 11, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Aug 12, 2022

mkhon commented Aug 12, 2022 via email

talregev commented Aug 12, 2022

JackBoosY commented Aug 12, 2022 • edited Loading

BillyONeal commented Aug 12, 2022

japm48 commented Aug 13, 2022

JackBoosY commented Aug 15, 2022

japm48 commented Aug 15, 2022 • edited Loading

BillyONeal commented Aug 15, 2022

talregev commented Aug 16, 2022

mkhon commented Sep 9, 2022

talregev commented Sep 9, 2022

mkhon commented Sep 12, 2022

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

mkhon commented May 26, 2022 •

edited

Loading

talregev commented May 26, 2022 •

edited

Loading

talregev commented May 26, 2022 •

edited

Loading

talregev commented May 26, 2022 •

edited

Loading

talregev commented Jun 1, 2022 •

edited

Loading

mkhon commented Jun 1, 2022 •

edited

Loading

talregev commented Aug 11, 2022 •

edited

Loading

talregev commented Aug 11, 2022 •

edited

Loading

JackBoosY commented Aug 12, 2022 •

edited

Loading

japm48 commented Aug 15, 2022 •

edited

Loading