[bitar] Add new port for bitar #25533
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for bitar have changed but the version was not updated
version: 0.0.1
old SHA: 0de32a367d5c009733455dab2ba76c9776d2cd6a
new SHA: 5923c69518c5803b8196b12c726525cc2f152f4a
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
I had a couple of unexpected errors from the CI that I didn't notice from my local development. Sorry for having multiple force pushes. But I think this PR has gotten to the point for reviewing. I will update the code according to your feedback. Thanks! |
ports/bitar/vcpkg.json
Outdated
| "description": "Bitar is a C++ library to simplify accessing hardware compression/decompression accelerators.", | ||
| "homepage": "https://github.com/ljishen/bitar", | ||
| "license": "MIT", | ||
| "supports": "linux", |
There was a problem hiding this comment.
IIUC bitar supports also freebsd.
There was a problem hiding this comment.
- I mean I'm expecting to have "bitar" to be one of dependencies of arrow in
arrow/vcpkg.json - All arrow relevant symbols/references in bitar will be weak, and therefore can be replaced/overrided by strong ones later when integrated into arrow. So no worry about existing of multiple arrow symbols.
- I will update the code and remove all arrow installed files from the bitar port.
- What should I suppose to do for the altering about no CI?
- Yes, I will add
freebsdto "supports".
There was a problem hiding this comment.
@dg0yt I've stopped installing arrow files by having changes in the upstream.
Cheney-W
added
the
category:new-port
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for bitar have changed but the version was not updated
version: 0.0.4
old SHA: 93629f3cbcb88d215280fc4bdb54d8c164889e54
new SHA: e3d713adacf64e6791f33daed5b9bda7abd0bfe0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
It looks like the port "libilbc" failed in the building. But I don't think I used it as one of the dependencies. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The CI still builds "libilbc". Do you know why it involves the building of this library? |
|
Could you please merge master for this PR? |
|
I tried to merge master, but I don't have permission to modify your pr. |
|
Sorry for the late reply. I'll merge it in these few days. |
|
Is work still being done for this PR? |
|
I've merged the master, but the CI still builds other irrelevant libraries. |
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DVCPKG_ROOT=${VCPKG_ROOT_DIR} | ||
| -DBITAR_FETCHCONTENT_OVERWRITE_CONFIGURATION=OFF) |
There was a problem hiding this comment.
This should be handled already since vcpkg_cmake_configure() passes "-DFETCHCONTENT_FULLY_DISCONNECTED=ON"
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'll close this PR because it is not needed anymore. |
Was it replaced by another port or PR? |
No. The same function is now officially supported by an SDK maintained by Nvidia. Unless I add distinct features to bitar, I think people will use their version instead of mine. |
Describe the pull request
Add the support for bitar, a C++ library to simplify accessing hardware compression/decompression accelerators.
Which triplets are supported/not supported? Have you updated the CI baseline?
Support only on Linux. And yes I updated file
ci.baseline.txt, because bitar only supports compiling with GCC>=10.Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes