[pcre2] Fix -mshstk needed with -fcf-protection #12347

c72578 · 2020-07-09T18:16:44Z

Describe the pull request

What does your PR fix? Fixes #
- Fixes the following error:
  src/sljit/sljitConfigInternal.h:219:2: error:
  #error "-mshstk is needed to compile with -fcf-protection"
- Upstream bug report:
  https://bugs.exim.org/show_bug.cgi?id=2578
- Add patch based on upstream commit:
  https://vcs.pcre.org/pcre2?view=revision&revision=1256
- Fixes [pcre2:x64-linux] build failure #12343
Which triplets are supported/not supported? Have you updated the CI baseline?
All official triplets are supported
Does your PR follow the maintainer guide?
Yes

- Fixes the following error: src/sljit/sljitConfigInternal.h:219:2: error: #error "-mshstk is needed to compile with -fcf-protection" - Upstream bug report: https://bugs.exim.org/show_bug.cgi?id=2578 - Add patch based on upstream commit: https://vcs.pcre.org/pcre2?view=revision&revision=1256 - Fixes microsoft#12343

cenit · 2020-07-10T07:13:12Z

fixes the #12343 issue also for me

ras0219-msft · 2020-07-13T20:01:11Z

Awesome job on the PR, thanks for all the information :) Thanks @cenit for the linked issue!

c72578 marked this pull request as ready for review July 9, 2020 19:19

LilyWangL requested a review from NancyLi1013 July 10, 2020 01:38

LilyWangL assigned NancyLi1013 Jul 10, 2020

NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 10, 2020

NancyLi1013 approved these changes Jul 10, 2020

View reviewed changes

c72578 mentioned this pull request Jul 10, 2020

[pcre2:x64-linux] build failure #12343

Closed

NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 10, 2020

Neumann-A mentioned this pull request Jul 11, 2020

[intl/gettext/fontconfig] update to native build system #11776

Merged

8 tasks

ras0219-msft merged commit a3eee82 into microsoft:master Jul 13, 2020

Provide feedback