Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pcre2:x64-linux] build failure #12343

Closed
cenit opened this issue Jul 9, 2020 · 3 comments · Fixed by #12347
Closed

[pcre2:x64-linux] build failure #12343

cenit opened this issue Jul 9, 2020 · 3 comments · Fixed by #12347
Assignees
@NancyLi1013
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@cenit
Copy link
Contributor

cenit commented Jul 9, 2020 •
edited
Loading

After #11754 has been merged, upgrade to latest revision fails here

Host Environment

  • OS: Ubuntu 20.04
  • Compiler: gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0

To Reproduce

./vcpkg install pcre2

Failure logs

FAILED: CMakeFiles/pcre2-8.dir/src/pcre2_jit_compile.c.o
/usr/bin/cc -DHAVE_CONFIG_H -DPCRE2_CODE_UNIT_WIDTH=8 -I. -I/home/user/vcpkg/buildtrees/pcre2/src/pcre2-10-b37153b2b1.clean -I/home/user/vcpkg/installed/x64-linux/include -fPIC -I"/home/user/vcpkg>
In file included from /home/user/vcpkg/buildtrees/pcre2/src/pcre2-10-b37153b2b1.clean/src/sljit/sljitLir.h:81,
                 from /home/user/vcpkg/buildtrees/pcre2/src/pcre2-10-b37153b2b1.clean/src/sljit/sljitLir.c:27,
                 from /home/user/vcpkg/buildtrees/pcre2/src/pcre2-10-b37153b2b1.clean/src/pcre2_jit_compile.c:79:
/home/user/vcpkg/buildtrees/pcre2/src/pcre2-10-b37153b2b1.clean/src/sljit/sljitConfigInternal.h:219:2: error: #error "-mshstk is needed to compile with -fcf-protection"
  219 | #error "-mshstk is needed to compile with -fcf-protection"
@c72578
Copy link
Contributor

c72578 commented Jul 9, 2020 •
edited
Loading

The upstream issue can be found here:
https://bugs.exim.org/show_bug.cgi?id=2578

Fixed in commit:
https://vcs.pcre.org/pcre2?view=revision&revision=1256

I will prepare a PR, which includes this patch

c72578 added a commit to c72578/vcpkg that referenced this issue Jul 9, 2020
@c72578
[pcre2] Fix -mshstk needed with -fcf-protection
83e7d70 
- Fixes the following error:
  src/sljit/sljitConfigInternal.h:219:2: error:
  #error "-mshstk is needed to compile with -fcf-protection"
- Upstream bug report:
  https://bugs.exim.org/show_bug.cgi?id=2578
- Add patch based on upstream commit:
  https://vcs.pcre.org/pcre2?view=revision&revision=1256
- Fixes microsoft#12343
@c72578 c72578 mentioned this issue Jul 9, 2020
Merged
@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 10, 2020
@c72578
Copy link
Contributor

c72578 commented Jul 10, 2020

@cenit, could you please test PR #12347, if it fixes the issue on your system?

@cenit
Copy link
Contributor Author

cenit commented Jul 10, 2020

hi @c72578, I tested your PR and pcre2 builds ok now. Thank you for the quick solution

ras0219-msft pushed a commit that referenced this issue Jul 13, 2020
@c72578
[pcre2] Fix -mshstk needed with -fcf-protection (#12347)
a3eee82 
- Fixes the following error:
  src/sljit/sljitConfigInternal.h:219:2: error:
  #error "-mshstk is needed to compile with -fcf-protection"
- Upstream bug report:
  https://bugs.exim.org/show_bug.cgi?id=2578
- Add patch based on upstream commit:
  https://vcs.pcre.org/pcre2?view=revision&revision=1256
- Fixes #12343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pcre2] Fix -mshstk needed with -fcf-protection c72578/vcpkg
3 participants
@c72578 @cenit @NancyLi1013