-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[intl/gettext/fontconfig] update to native build system #11776
Conversation
@Neumann-A, could you resolve the conficts? |
waiting for merge of #11550 before i touch this again. Furthermore this PR is still in draft. |
@BillyONeal: this PR also requires VM update: 565220e I wonder if I should just add all of: vcpkg/scripts/cmake/vcpkg_configure_make.cmake Lines 147 to 159 in a3eee82
for symmetry (for some reason autopoint is missing there.) |
@Neumann-A Thanks! |
aa3e396
to
9086007
Compare
@JackBoosY: I'll reset this PR after #11836 is merged so don't rerun CI for this PR. |
It looks like this is depends:vm-update for Ubuntu 20.04 but changes to do that aren't here; that's probably worth being its own thing though |
@BillyONeal the vm update should have been autopoint not ubuntu 20.04. Compiling on a lower linux version should be ok. Just starting an executable using fontconfig requires extra setup. (although newer version in binary and older on system could probably be fine) |
@BillyONeal here is the comment to the vm update request: #11776 (comment) |
b571339
to
f92b9a7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Seems okay, ready for review now? |
@JackBoosY Yes |
I think this PR also fix #13566. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things I noticed :) This is amazing tho!
# Conflicts: # ports/libidn2/CONTROL
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Alright! Awesome! Thanks so much @Neumann-A 😄 😄 😄 |
With this PR cmake built on ubuntu 20.04 with vcpkg can be correctly started (no font rendering problems; Only tested with setting FONTCONFIG_FILE to font.conf installed by VCPKG)
Depends on other PRs which need to be merged first
closes #12330
closes #11165
closes #14548
closes #13566 (? If it fixes the issue it is more a coincidental fix since uuid will be linked elsewhere. The root cause for the issue is probably in qt5 buildsystem)