-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libxml2] Update to latest commit, remove wrapper #14588
Conversation
cc @Neumann-A for review this PR. |
FYI the upstream libxml2 project now has an official CMake build system (see https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/CMakeLists.txt), and even the autotools build system installs a CMake config file (see https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/libxml2-config.cmake.in). I am a bit afraid that adding a third vcpkg-specific variant will complicate life of libraries maintainers that need to support all this variants. |
@traversaro That's awesome, I will try to update libxml2 to use that (but it's not included in official release). |
is there a reason not to switch to |
@Neumann-A If |
no no no..... don't do that. You are patching the hell out of downstream ports for some unnecessary reason. Fix the CMake You can override all manual |
@Neumann-A I've already realized that... Will open another PR to fix the related bug. |
CMakeLists.txt
vcpkg-cmake-wrapper
andusage
since the official already provide the cmake targetReplaced PR #14478.
Fixes #14468.