Add a setting for disabling rendering "intense" text as bold #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Rendering
carlos-zamora
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
I'm approving, but please don't forget to...
- update the schema
- update the docs
I don't like that the setting is called disableIntenseIsBold. I wish we could remove the "disable" part, but then we would have a setting that defaults to true, and that's not great either. So imo, it's fine.
src/renderer/dx/DxRenderer.hpp
Outdated
| @@ -252,6 +254,7 @@ namespace Microsoft::Console::Render | |||
| // Preferences and overrides | |||
| bool _softwareRendering; | |||
| bool _forceFullRepaintRendering; | |||
| bool _intenseIsBold{ true }; | |||
There was a problem hiding this comment.
nit: looks like all of the other ones are initialized in the ctor. We should probably move this there for consistency
There was a problem hiding this comment.
We should start moving these things into the header honestly.
| @@ -402,6 +402,7 @@ | |||
| IsChecked="{x:Bind IsBellStyleFlagSet(4), BindBack=SetBellStyleTaskbar, Mode=TwoWay}" /> | |||
| </StackPanel> | |||
| </local:SettingContainer> | |||
|
|
|||
There was a problem hiding this comment.
Ah, I see you thought you had to edit Profiles.xaml haha. You can definitely undo this one.
|
Thanks @zadjii-msft for this! Off: this seems to be a good place to also add “intense as bright” option. But I never really know where bright is enabled in DX engine. |
PankajBhojwani
approved these changes
Jul 14, 2021
…sable-intense-is-bold
|
I'm gonna close this PR, as to not pollute this PR that's already got green checks. From discussion in sync today - we're not gonna implement the setting this way right now. We're instead gonna do the EnumFlagMapper thing, and do |
5 tasks
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2021
…10759) ## Summary of the Pull Request This adds a new setting `intenseTextStyle`. It's a per-appearance, control setting, defaulting to `"all"`. * When set to `"all"` or `["bold", "bright"]`, then we'll render text as both **bold** and bright (1.10 behavior) * When set to `"bold"`, `["bold"]`, we'll render text formatted with `^[[1m` as **bold**, but not bright * When set to `"bright"`, `["bright"]`, we'll render text formatted with `^[[1m` as bright, but not bold. This is the pre 1.10 behavior * When set to `"none"`, we won't do anything special for it at all. ## references * I last did this in #10648. This time it's an enum, so we can add bright in the future. It's got positive wording this time. * ~We will want to add `"bright"` as a value in the future, to disable the auto intense->bright conversion.~ I just did that now. * #5682 is related ## PR Checklist * [x] Closes #10576 * [x] I seriously don't think we have an issue for "disable intense is bright", but I'm not crazy, people wanted that, right? #2916 (comment) was the closest * [x] I work here * [x] Tests added/passed * [x] MicrosoftDocs/terminal#381 ## Validation Steps Performed <!--  -->  Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray. ### EDIT, 10 Aug ```json "intenseTextStyle": "none", "intenseTextStyle": "bold", "intenseTextStyle": "bright", "intenseTextStyle": "all", "intenseTextStyle": ["bold", "bright"], ``` all work now. Repro script: ```sh printf "\e[1m[bold]\e[m[normal]\e[34m[blue]\e[1m[bold blue]\e[m\n" ```
DHowett
pushed a commit
that referenced
this pull request
Aug 25, 2021
…10759) This adds a new setting `intenseTextStyle`. It's a per-appearance, control setting, defaulting to `"all"`. * When set to `"all"` or `["bold", "bright"]`, then we'll render text as both **bold** and bright (1.10 behavior) * When set to `"bold"`, `["bold"]`, we'll render text formatted with `^[[1m` as **bold**, but not bright * When set to `"bright"`, `["bright"]`, we'll render text formatted with `^[[1m` as bright, but not bold. This is the pre 1.10 behavior * When set to `"none"`, we won't do anything special for it at all. * I last did this in #10648. This time it's an enum, so we can add bright in the future. It's got positive wording this time. * ~We will want to add `"bright"` as a value in the future, to disable the auto intense->bright conversion.~ I just did that now. * #5682 is related * [x] Closes #10576 * [x] I seriously don't think we have an issue for "disable intense is bright", but I'm not crazy, people wanted that, right? #2916 (comment) was the closest * [x] I work here * [x] Tests added/passed * [x] MicrosoftDocs/terminal#381 <!--  -->  Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray. ```json "intenseTextStyle": "none", "intenseTextStyle": "bold", "intenseTextStyle": "bright", "intenseTextStyle": "all", "intenseTextStyle": ["bold", "bright"], ``` all work now. Repro script: ```sh printf "\e[1m[bold]\e[m[normal]\e[34m[blue]\e[1m[bold blue]\e[m\n" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds a new setting
disableIntenseIsBold. It's a per-appearance, control setting, defaulting tofalse.^[[1mas bold. (the 1.10+ default)PR Checklist
Validation Steps Performed
Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray.